From fb2467bdb9dc50636183ff4a82e10463a83e47a3 Mon Sep 17 00:00:00 2001 From: Xan-Asc <119889093+Xan-Asc@users.noreply.github.com> Date: Fri, 17 Nov 2023 05:59:00 -0800 Subject: [PATCH] Bugfix: filter out tradeskills that don't craft --- TradeSkillMaster_Crafting/Modules/CraftingGUI.lua | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/TradeSkillMaster_Crafting/Modules/CraftingGUI.lua b/TradeSkillMaster_Crafting/Modules/CraftingGUI.lua index 2b5c2fd..b4f7d68 100644 --- a/TradeSkillMaster_Crafting/Modules/CraftingGUI.lua +++ b/TradeSkillMaster_Crafting/Modules/CraftingGUI.lua @@ -16,6 +16,14 @@ local private = {} private.gather = {} private.shown = {} +-- list of profession skills that do not have crafting. used by UpdateTradeSkills +local invalidTrade = { + ["Herbalism"] = true, + ["Skinning"] = true, + ["Fishing"] = true, + ["Riding"] = true +} + -- Helper function to find spellID associated to spellname local function GetTradeSkillSpellID(spellName) -- GetTradeSkillRecipeLink ONLY works when a trade skill window is open, but this should always happen @@ -273,8 +281,8 @@ function GUI:UpdateTradeSkills(...) elseif skillName == "Weapon Skills" then inSecondary = false elseif inProfessions == true or inSecondary == true then - if skillName ~= nil and (not filterTrade or filterTrade == skillName)then --- if skillName == "Mining" then skillName = "Smelting" end -- bandaid for mining as related spell is different than craft + if skillName ~= nil and (not filterTrade or filterTrade == skillName) and not invalidTrade[skillName] then + if skillName == "Mining" then skillName = "Smelting" end -- bandaid for mining as related spell is different than craft TSM.db.realm.tradeSkills[playerName][skillName] = old[skillName] or {} TSM.db.realm.tradeSkills[playerName][skillName].level = skillRank TSM.db.realm.tradeSkills[playerName][skillName].maxLevel = skillMaxRank