Merge branch 'master' of https://github.com/mosra/magnum-bindings into pyArrayHolderMissingMove

doc/python/conf.py

@@ -164,6 +164,7 @@ INPUT_PAGES = [
     'pages/api-conventions.rst',
     'pages/changelog.rst',
     'pages/credits.rst',
+    'pages/developers.rst',
 
     '../../../magnum-examples/doc/python/examples.rst'
 ]

doc/python/pages/changelog.rst

@@ -67,7 +67,8 @@ Changelog
     issues with shitty IDE indexers such as Eclipse, confusing these with
     Python's ``<Python.h>``
 -   Minor performance fixes (see :gh:`mosra/magnum-bindings#10`,
-    :gh:`mosra/magnum-bindings#15`)
+    :gh:`mosra/magnum-bindings#15`,
+    :gh:`mosra/magnum-bindings#16`)
     Travis banned everyone from using their CI and so all Linux and macOS
     builds were migrated from Travis to Circle CI. See also
     :gh:`mosra/magnum#350` and :gh:`mosra/magnum#523`.

doc/python/pages/developers.rst

@@ -30,7 +30,14 @@ Developers Guide
     corrade
     magnum
 :summary: Checklists for developing new things in Magnum Python bindings
-    themselves
+    themselves.
+
+.. role:: cmake(code)
+    :language: cmake
+.. role:: cpp(code)
+    :language: c++
+.. role:: py(code)
+    :language: py
 
 `Checklist for adding / removing bindings for a library`_
 =========================================================

src/python/magnum/gl.cpp

@@ -364,10 +364,10 @@ void gl(py::module_& m) {
         corrade::enumOperators(contextDetectedDriver);
 
         context
-            .def_property_readonly_static("has_current", [](py::object) {
+            .def_property_readonly_static("has_current", [](const py::object&) {
                 return GL::Context::hasCurrent();
             }, "Whether there is any current context")
-            .def_property_readonly_static("current", [](py::object) {
+            .def_property_readonly_static("current", [](const py::object&) {
                 if(!GL::Context::hasCurrent()) {
                     PyErr_SetString(PyExc_RuntimeError, "no current context");
                     throw py::error_already_set{};
@@ -901,7 +901,7 @@ void gl(py::module_& m) {
         .def(py::init<MeshPrimitive>(), "Constructor", py::arg("primitive"))
         .def_property_readonly("id", &GL::Mesh::id, "OpenGL vertex array ID")
         .def_property("primitive", &GL::Mesh::primitive,
-            [](GL::Mesh& self, py::object primitive) {
+            [](GL::Mesh& self, const py::object &primitive) {
                 if(py::isinstance<MeshPrimitive>(primitive))
                     self.setPrimitive(py::cast<MeshPrimitive>(primitive));
                 else if(py::isinstance<GL::MeshPrimitive>(primitive))
@@ -1100,10 +1100,10 @@ void gl(py::module_& m) {
             #endif
 
             /** @todo FFS why do I have to pass the class as first argument?! */
-            .def_property_static("clear_color", nullptr, [](py::object, const Color4& color) {
+            .def_property_static("clear_color", nullptr, [](const py::object&, const Color4& color) {
                 GL::Renderer::setClearColor(color);
             }, "Set clear color")
-            .def_property_readonly_static("error", [](py::object) {
+            .def_property_readonly_static("error", [](const py::object&) {
                 return GL::Renderer::error();
             }, "Error status");
     }

src/python/magnum/platform/cgl.cpp

@@ -63,7 +63,7 @@ void cgl(py::module_& m) {
 
         /* The base doesn't have a virtual destructor because in C++ it's never
            deleted through a pointer to the base. Here we need it, though. */
-        virtual ~PyWindowlessApplication() {}
+        virtual ~PyWindowlessApplication() = default;
     };
 
     py::class_<PyWindowlessApplication, ApplicationHolder<PyWindowlessApplication>> windowlessGlxApplication{m, "WindowlessApplication", "Windowless CGL application"};

src/python/magnum/platform/egl.cpp

@@ -63,7 +63,7 @@ void egl(py::module_& m) {
 
         /* The base doesn't have a virtual destructor because in C++ it's never
            deleted through a pointer to the base. Here we need it, though. */
-        virtual ~PyWindowlessApplication() {}
+        virtual ~PyWindowlessApplication() = default;
     };
 
     py::class_<PyWindowlessApplication, ApplicationHolder<PyWindowlessApplication>> windowlessEglApplication{m, "WindowlessApplication", "Windowless EGL application"};

src/python/magnum/platform/glfw.cpp

@@ -64,7 +64,7 @@ void glfw(py::module_& m) {
 
         /* The base doesn't have a virtual destructor because in C++ it's never
            deleted through a pointer to the base. Here we need it, though. */
-        virtual ~PublicizedApplication() {}
+        virtual ~PublicizedApplication() = default;
     };
 
     struct PyApplication: PublicizedApplication {

src/python/magnum/platform/glx.cpp

@@ -63,7 +63,7 @@ void glx(py::module_& m) {
 
         /* The base doesn't have a virtual destructor because in C++ it's never
            deleted through a pointer to the base. Here we need it, though. */
-        virtual ~PyWindowlessApplication() {}
+        virtual ~PyWindowlessApplication() = default;
     };
 
     py::class_<PyWindowlessApplication, ApplicationHolder<PyWindowlessApplication>> windowlessGlxApplication{m, "WindowlessApplication", "Windowless GLX application"};

src/python/magnum/platform/sdl2.cpp

@@ -64,7 +64,7 @@ void sdl2(py::module_& m) {
 
         /* The base doesn't have a virtual destructor because in C++ it's never
            deleted through a pointer to the base. Here we need it, though. */
-        virtual ~PublicizedApplication() {}
+        virtual ~PublicizedApplication() = default;
     };
 
     struct PyApplication: PublicizedApplication {

src/python/magnum/platform/wgl.cpp

@@ -63,7 +63,7 @@ void wgl(py::module_& m) {
 
         /* The base doesn't have a virtual destructor because in C++ it's never
            deleted through a pointer to the base. Here we need it, though. */
-        virtual ~PyWindowlessApplication() {}
+        virtual ~PyWindowlessApplication() = default;
     };
 
     py::class_<PyWindowlessApplication, ApplicationHolder<PyWindowlessApplication>> windowlessWglApplication{m, "WindowlessApplication", "Windowless WGL application"};