From 2373d2dc9e5700ccb60a42ab28443b7bcdc8704c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= <mosra@centrum.cz>
Date: Wed, 17 May 2023 13:57:59 +0200
Subject: [PATCH] python: BitArray is implicitly convertible to
 [Mutable]BitArrayView.

Which makes the constructor of a StridedArrayView from a BitArray
redundant.
---
 src/python/corrade/containers.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/python/corrade/containers.cpp b/src/python/corrade/containers.cpp
index ebb51c5..92cc6f1 100644
--- a/src/python/corrade/containers.cpp
+++ b/src/python/corrade/containers.cpp
@@ -184,6 +184,9 @@ template<class T> void arrayView(py::class_<Containers::ArrayView<T>, Containers
 }
 
 template<class T> void bitArrayView(py::class_<Containers::BasicBitArrayView<T>, Containers::PyArrayViewHolder<Containers::BasicBitArrayView<T>>>& c) {
+    /* Implicitly convertible from a BitArray */
+    py::implicitly_convertible<Containers::BitArray, Containers::BasicBitArrayView<T>>();
+
     c
         /* Constructor */
         .def(py::init(), "Default constructor")
@@ -678,9 +681,6 @@ template<unsigned dimensions, class T> void stridedBitArrayView(py::class_<Conta
 
 template<class T> void stridedBitArrayView1D(py::class_<Containers::BasicStridedBitArrayView<1, T>, Containers::PyArrayViewHolder<Containers::BasicStridedBitArrayView<1, T>>>& c) {
     c
-        .def(py::init([](Containers::BitArray& other) {
-            return pyArrayViewHolder(Containers::BasicStridedBitArrayView<1, T>{Containers::BasicBitArrayView<T>{other}}, other.size() ? py::cast(other) : py::none{});
-        }), "Construct a view on a bit array", py::arg("array"))
         .def(py::init([](Containers::BasicBitArrayView<T>& other) {
             return pyArrayViewHolder(Containers::BasicStridedBitArrayView<1, T>{other}, pyObjectHolderFor<Containers::PyArrayViewHolder>(other).owner);
         }), "Construct from a bit array view", py::arg("view"))