ic
/
magnum-bindings
6
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

Apply clang-tidy performance fixes

pull/10/head
Aaron Gokaslan 6 years ago
parent
4bb19e0b3f
commit
41b720e44c
2 changed files with 5 additions and 5 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      src/python/corrade/containers.cpp
  2. 8
      src/python/magnum/gl.cpp

2
src/python/corrade/containers.cpp
Unescape View File

@ -51,7 +51,7 @@ struct Slice {
std::ptrdiff_t step; std::ptrdiff_t step;
}; };
Slice calculateSlice(py::slice slice, std::size_t containerSize) { Slice calculateSlice(const py::slice& slice, std::size_t containerSize) {
std::size_t size; std::size_t size;
std::ptrdiff_t start, stop, step; std::ptrdiff_t start, stop, step;

8
src/python/magnum/gl.cpp
Unescape View File

@ -110,7 +110,7 @@ template<UnsignedInt dimensions> void texture(py::class_<GL::Texture<dimensions>
.def_property("max_level", nullptr, &GL::Texture<dimensions>::setMaxLevel, "Max mip level") .def_property("max_level", nullptr, &GL::Texture<dimensions>::setMaxLevel, "Max mip level")
#endif #endif
.def_property("minification_filter", nullptr, .def_property("minification_filter", nullptr,
[](GL::Texture<dimensions>& self, py::object value) { [](GL::Texture<dimensions>& self, const py::object& value) {
if(py::isinstance<SamplerFilter>(value)) if(py::isinstance<SamplerFilter>(value))
self.setMinificationFilter(py::cast<SamplerFilter>(value)); self.setMinificationFilter(py::cast<SamplerFilter>(value));
else if(py::isinstance<GL::SamplerFilter>(value)) else if(py::isinstance<GL::SamplerFilter>(value))
@ -145,7 +145,7 @@ template<UnsignedInt dimensions> void texture(py::class_<GL::Texture<dimensions>
} }
}, "Minification filter") }, "Minification filter")
.def_property("magnification_filter", nullptr, .def_property("magnification_filter", nullptr,
[](GL::Texture<dimensions>& self, py::object filter) { [](GL::Texture<dimensions>& self, const py::object& filter) {
if(py::isinstance<SamplerFilter>(filter)) if(py::isinstance<SamplerFilter>(filter))
self.setMagnificationFilter(py::cast<SamplerFilter>(filter)); self.setMagnificationFilter(py::cast<SamplerFilter>(filter));
else if(py::isinstance<GL::SamplerFilter>(filter)) else if(py::isinstance<GL::SamplerFilter>(filter))
@ -163,7 +163,7 @@ template<UnsignedInt dimensions> void texture(py::class_<GL::Texture<dimensions>
.def_property("lod_bias", nullptr, &GL::Texture<dimensions>::setLodBias, "Level-of-detail bias") .def_property("lod_bias", nullptr, &GL::Texture<dimensions>::setLodBias, "Level-of-detail bias")
#endif #endif
.def_property("wrapping", nullptr, .def_property("wrapping", nullptr,
[](GL::Texture<dimensions>& self, py::object wrapping) { [](GL::Texture<dimensions>& self, const py::object& wrapping) {
/** @todo accept two/three different values as well */ /** @todo accept two/three different values as well */
if(py::isinstance<SamplerWrapping>(wrapping)) if(py::isinstance<SamplerWrapping>(wrapping))
self.setWrapping(py::cast<SamplerWrapping>(wrapping)); self.setWrapping(py::cast<SamplerWrapping>(wrapping));
@ -179,7 +179,7 @@ template<UnsignedInt dimensions> void texture(py::class_<GL::Texture<dimensions>
#ifdef MAGNUM_TARGET_GLES2 #ifdef MAGNUM_TARGET_GLES2
&GL::Texture<dimensions>::setBorderColor, &GL::Texture<dimensions>::setBorderColor,
#else #else
[](GL::Texture<dimensions>& self, py::object color) { [](GL::Texture<dimensions>& self, const py::object& color) {
if(py::isinstance<Vector3>(color)) if(py::isinstance<Vector3>(color))
self.setBorderColor(py::cast<Vector3>(color)); self.setBorderColor(py::cast<Vector3>(color));
else if(py::isinstance<Vector4>(color)) else if(py::isinstance<Vector4>(color))

Write Preview
Loading…
Cancel
Save