From 695c40b2d1a0df1ced64483e73026d0b5b1c2839 Mon Sep 17 00:00:00 2001 From: Aaron Gokaslan Date: Wed, 5 Oct 2022 12:16:52 -0400 Subject: [PATCH] python: more missing moves, unnecessary inc_ref. --- src/Corrade/Containers/OptionalPythonBindings.h | 2 +- src/Magnum/PythonBindings.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Corrade/Containers/OptionalPythonBindings.h b/src/Corrade/Containers/OptionalPythonBindings.h index c9cad5f..fbfc205 100644 --- a/src/Corrade/Containers/OptionalPythonBindings.h +++ b/src/Corrade/Containers/OptionalPythonBindings.h @@ -37,7 +37,7 @@ template struct type_caster> { using value_conv = make_caster; template static handle cast(T_&& src, const return_value_policy policy, const handle parent) { - if(!src) return none{}.inc_ref(); + if(!src) return none{}.release(); return value_conv::cast(*std::forward(src), return_value_policy_override::policy(policy), parent); } diff --git a/src/Magnum/PythonBindings.h b/src/Magnum/PythonBindings.h index 7150d4a..ff4d871 100644 --- a/src/Magnum/PythonBindings.h +++ b/src/Magnum/PythonBindings.h @@ -45,7 +45,7 @@ template struct PyImageViewHolder: std::unique_ptr { }; template PyImageViewHolder pyImageViewHolder(const T& view, pybind11::object owner) { - return PyImageViewHolder{new T{view}, owner}; + return PyImageViewHolder{new T{view}, std::move(owner)}; } }