From 90b73a9d218cffda37a90050e6133a2c43caa2a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Sverre=20Lien=20Sell=C3=A6g?= Date: Tue, 31 Mar 2026 14:51:22 +0200 Subject: [PATCH] update python bindings --- src/python/CMakeLists.txt | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/python/CMakeLists.txt b/src/python/CMakeLists.txt index 6f4ceff..1a52f7b 100644 --- a/src/python/CMakeLists.txt +++ b/src/python/CMakeLists.txt @@ -35,16 +35,10 @@ elseif(NOT pybind11_VERSION) set(pybind11_VERSION ${PYBIND11_VERSION_MAJOR}.${PYBIND11_VERSION_MINOR}.${PYBIND11_VERSION_PATCH}) endif() -# In pybind11 2.2.4 and below, pybind11_add_module() added the include -# directories as non-system. That, combined with Corrade's warning level, added -# an insane amount of warnings to the build. Since 2.3 it was possible to -# override that by passing SYSTEM to pybind11_add_module(), HOWEVER since 2.6 -# doing so causes an ANNOYING warning because they made that a default. That -# all in a span of barely two years. Can't things just stay stable for a little -# moment?! -if(pybind11_VERSION VERSION_LESS 2.6) - set(pybind11_add_module_SYSTEM SYSTEM) -endif() +# Newer pybind11 versions route pybind11_add_module() through FindPython and no +# longer accept SYSTEM as a positional compatibility argument. Keep this empty +# in the Oasis superproject build. +set(pybind11_add_module_SYSTEM) # UGH FFS get_property(CMAKE_GENERATOR_IS_MULTI_CONFIG GLOBAL PROPERTY GENERATOR_IS_MULTI_CONFIG)