From a325f3d0c15ccc173118d00dfddf896ae2fb43b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Wed, 30 Mar 2022 20:12:43 +0200 Subject: [PATCH] python: minor, doc++, add TODOs. --- src/python/magnum/test/test_trade.py | 2 +- src/python/magnum/trade.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/python/magnum/test/test_trade.py b/src/python/magnum/test/test_trade.py index 683b96f..f2bb56b 100644 --- a/src/python/magnum/test/test_trade.py +++ b/src/python/magnum/test/test_trade.py @@ -264,4 +264,4 @@ class Importer(unittest.TestCase): importer.open_data(b'bla') with self.assertRaisesRegex(RuntimeError, "import failed"): - image = importer.image2d(0) + importer.image2d(0) diff --git a/src/python/magnum/trade.cpp b/src/python/magnum/trade.cpp index 33a194b..22660f6 100644 --- a/src/python/magnum/trade.cpp +++ b/src/python/magnum/trade.cpp @@ -298,6 +298,7 @@ void trade(py::module_& m) { .def("mesh_name", checkOpenedBoundsReturnsString<&Trade::AbstractImporter::meshName, &Trade::AbstractImporter::meshCount>, "Mesh name", py::arg("id")) .def("mesh", checkOpenedBoundsResult, "Mesh", py::arg("id"), py::arg("level") = 0) /** @todo mesh_attribute_for_name / mesh_attribute_name */ + /** @todo access by name, not just name -> id resolving */ .def_property_readonly("image1d_count", checkOpened, "One-dimensional image count") .def_property_readonly("image2d_count", checkOpened, "Two-dimensional image count") @@ -315,7 +316,7 @@ void trade(py::module_& m) { .def("image2d", checkOpenedBoundsResult, "Two-dimensional image", py::arg("id"), py::arg("level") = 0) .def("image3d", checkOpenedBoundsResult, "Three-dimensional image", py::arg("id"), py::arg("level") = 0); - py::class_, PluginManager::AbstractManager> importerManager{m, "ImporterManager", "Plugin manager for importer plugins"}; + py::class_, PluginManager::AbstractManager> importerManager{m, "ImporterManager", "Manager for importer plugins"}; corrade::manager(importerManager); }