From c2499fea349d5fa1633837785058bd684cafe894 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Fri, 2 Sep 2022 20:28:52 +0200 Subject: [PATCH] python: no need to bind draw() again for shader subclasses. The inheritance takes care of that. On the other hand it makes docs rather noisy, but that's another problem to fix. --- src/python/magnum/shaders.cpp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/python/magnum/shaders.cpp b/src/python/magnum/shaders.cpp index e16df33..2cd32f9 100644 --- a/src/python/magnum/shaders.cpp +++ b/src/python/magnum/shaders.cpp @@ -44,12 +44,6 @@ namespace magnum { namespace { -template void anyShader(PyNonDestructibleClass& c) { - c.def("draw", [](GL::AbstractShaderProgram& self, GL::Mesh& mesh) { - self.draw(mesh); - }, "Draw a mesh"); -} - template void flat(PyNonDestructibleClass, GL::AbstractShaderProgram>& c) { /* Attributes */ c.attr("TEXTURE_COORDINATES") = GL::DynamicAttribute{typename Shaders::FlatGL::TextureCoordinates{}}; @@ -84,8 +78,6 @@ template void flat(PyNonDestructibleClass void vertexColor(PyNonDestructibleClass, GL::AbstractShaderProgram>& c) { @@ -101,8 +93,6 @@ template void vertexColor(PyNonDestructibleClass::setTransformationProjectionMatrix, "Transformation and projection matrix"); - - anyShader(c); } } @@ -314,8 +304,6 @@ void shaders(py::module_& m) { self.bindTextures(ambient, diffuse, specular, normal); }, "Bind textures", py::arg("ambient") = nullptr, py::arg("diffuse") = nullptr, py::arg("specular") = nullptr, py::arg("normal") = nullptr) ; - - anyShader(phongGL); } }