From f8a3130d732f9770ebd1732db71338a0353e8b42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sun, 4 Jan 2026 22:58:22 +0100 Subject: [PATCH] package/ci: explicitly add SDL DLL path for static Windows builds. On shared builds it's not needed as it is never actually imported by any tests, so there the autodetection alone is sufficient. --- package/ci/appveyor-desktop.bat | 2 +- package/ci/appveyor.yml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/package/ci/appveyor-desktop.bat b/package/ci/appveyor-desktop.bat index bfebdec..a1b644f 100644 --- a/package/ci/appveyor-desktop.bat +++ b/package/ci/appveyor-desktop.bat @@ -119,7 +119,7 @@ cmake .. ^ -DPYBIND11_PYTHON_VERSION=3.%PYTHON% ^ -DMAGNUM_WITH_PYTHON=ON ^ -DMAGNUM_BUILD_TESTS=ON ^ - %COMPILER_EXTRA% -G Ninja || exit /b + %COMPILER_EXTRA% %BINDINGS_EXTRA% -G Ninja || exit /b cmake --build . || exit /b cmake --build . --target install || exit /b diff --git a/package/ci/appveyor.yml b/package/ci/appveyor.yml index e4ab5f3..a6adc26 100644 --- a/package/ci/appveyor.yml +++ b/package/ci/appveyor.yml @@ -28,6 +28,9 @@ environment: BUILD_STATIC: ON PYTHON: 8 PYBIND: 2.3.0 + # The static build puts everything including Sdl2Application together so it + # needs the SDL DLL directory as well + BINDINGS_EXTRA: "-DMAGNUM_PYTHON_BINDINGS_DLL_PATH=C:/projects/magnum-bindings/deps/bin;C:/projects/magnum-bindings/SDL/lib/x64" - TARGET: desktop COMPILER: msvc APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022 @@ -35,6 +38,9 @@ environment: BUILD_STATIC: ON PYTHON: 8 PYBIND: 2.9.0 # first supporting MSVC 2022 + # The static build puts everything including Sdl2Application together so it + # needs the SDL DLL directory as well + BINDINGS_EXTRA: "-DMAGNUM_PYTHON_BINDINGS_DLL_PATH=C:/projects/magnum-bindings/deps/bin;C:/projects/magnum-bindings/SDL/lib/x64" # clang-cl crashes with pybind11, "Illegal instruction" and # lld-link: warning: ignoring unknown argument '-flto' # LLVM ERROR: Associative COMDAT symbol '??0type_error@pybind11@@QEAA@PEBD@Z' does not exist.