From fa3c0bdd0571f1125686c7a85ba62d3ab28c72c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sat, 27 Jul 2019 20:21:13 +0200 Subject: [PATCH] python: better name for the gl.Framebuffer attachment owners property. --- src/python/magnum/gl.cpp | 2 +- src/python/magnum/test/test_gl_gl.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/python/magnum/gl.cpp b/src/python/magnum/gl.cpp index c33eb5b..cc4377b 100644 --- a/src/python/magnum/gl.cpp +++ b/src/python/magnum/gl.cpp @@ -345,7 +345,7 @@ void gl(py::module& m) { pyObjectHolderFor(self).attachments.emplace_back(pyObjectFromInstance(renderbuffer)); }, "Attach renderbuffer to given buffer") - .def_property_readonly("attached", [](GL::Framebuffer& self) { + .def_property_readonly("attachments", [](GL::Framebuffer& self) { return pyObjectHolderFor(self).attachments; }, "Renderbuffer and texture objects referenced by the framebuffer"); diff --git a/src/python/magnum/test/test_gl_gl.py b/src/python/magnum/test/test_gl_gl.py index f4eadee..4daf601 100644 --- a/src/python/magnum/test/test_gl_gl.py +++ b/src/python/magnum/test/test_gl_gl.py @@ -61,7 +61,7 @@ class Framebuffer(GLTestCase): def test(self): framebuffer = gl.Framebuffer(((0, 0), (4, 4))) self.assertNotEqual(framebuffer.id, 0) - self.assertEqual(len(framebuffer.attached), 0) + self.assertEqual(len(framebuffer.attachments), 0) def test_attach(self): renderbuffer = gl.Renderbuffer() @@ -70,8 +70,8 @@ class Framebuffer(GLTestCase): framebuffer = gl.Framebuffer(((0, 0), (4, 4))) framebuffer.attach_renderbuffer(gl.Framebuffer.ColorAttachment(0), renderbuffer) - self.assertEqual(len(framebuffer.attached), 1) - self.assertIs(framebuffer.attached[0], renderbuffer) + self.assertEqual(len(framebuffer.attachments), 1) + self.assertIs(framebuffer.attachments[0], renderbuffer) self.assertEqual(sys.getrefcount(renderbuffer), renderbuffer_refcount + 1) def test_read(self):