|
|
|
|
/*
|
|
|
|
|
This file is part of Magnum.
|
|
|
|
|
|
|
|
|
|
Copyright © 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019,
|
|
|
|
|
2020 Vladimír Vondruš <mosra@centrum.cz>
|
|
|
|
|
|
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
|
copy of this software and associated documentation files (the "Software"),
|
|
|
|
|
to deal in the Software without restriction, including without limitation
|
|
|
|
|
the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
|
and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
|
Software is furnished to do so, subject to the following conditions:
|
|
|
|
|
|
|
|
|
|
The above copyright notice and this permission notice shall be included
|
|
|
|
|
in all copies or substantial portions of the Software.
|
|
|
|
|
|
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
|
THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
|
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
|
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
|
|
|
DEALINGS IN THE SOFTWARE.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <new>
|
Vk: initial APIs for binding a memory to an image.
You won't believe it, but it took me over a month of sitting on the
shitter until this design idea materialized out of [..] air. The whole
story, in order:
- Vulkan doesn't allow one VkDeviceMemory to be mapped more than once.
This is rather sad, because since Vulkan best practices suggest to
allocate a large block and suballocate from that, the engine needs
an extra layer that "emulates" mapping the suballocations for the
users but behind the scenes it inevitably has to map the whole
VkDeviceMemory anyway and keep it mapped for as long as any of the
sub-mappings is active.
- Because if it would map just a certain suballocation and then the
user would want to map another suballocation, it would have to
discard the original mapping and create a new one spanning both
suballocations and that has a risk of suddenly being in a different
VM block, making all pointers to the previous mapping invalid.
- The Vulkan Memory Allocator implements this approach of mapping the
whole thing and because of all the bookkeeping it doesn't give a
direct access to the underlying VkDeviceMemory, making it rather
hard to integrate.
Here I realized that:
- Most allocations won't need to be mapped ever, so the hiding and
obfuscation done by VMA isn't needed for those --- and we want
interoperability with 3rd party code, so preventing access to
VkDeviceMemory is out of question.
- There's KHR_dedicated_allocation, which (probably?) wasn't around
when VMA was originally designed. The extension was created because
a dedicated allocation actually *does* make sense in certain
cases and on certain architectures. Providing a way to make those
thus shouldn't be something "temporary, until a real allocator
exists" but rather a well-designed API that's there to stay.
- Except for iGPUs, the usual way to populate a GPU buffer would be to
first copy the data to some host-accessible scratch buffer and then
do a GPU-side copy of that buffer to a device-local memory. The
scratch buffer is very likely to have a vastly different
suballocation scheme than GPU buffers (grow & discard everything
once it's all uploaded, for example) so again trying to put the two
under the same allocator umbrella doesn't make sense.
Thus:
- To avoid implementing a full-blown allocator right from the start,
we'll first provide convenience APIs only for dedicated allocations
-- making it possible to transfer memory ownership to an
Image/Buffer so it can be treated the same way as in GL, and later
having the Image/Buffer constructor implicitly allocate a dedicated
VkDeviceMemory.
- This default allocation will be subsequently equipped with
KHR_dedicated_allocation bits.
- Thanks to the extensible/layered nature of the design, the user is
still capable of being completely in control of allocations,
managing VkDeviceMemory sub-allocations by hand.
Finally, once allocator APIs are figured out, the default Buffer/Image
behavior gets switched from a dedicated allocation to using an
allocator, and dedicated allocation will be only used if the
KHR_dedicated_allocation bit is requested.
6 years ago
|
|
|
#include <sstream>
|
|
|
|
|
#include <Corrade/TestSuite/Tester.h>
|
Vk: initial APIs for binding a memory to an image.
You won't believe it, but it took me over a month of sitting on the
shitter until this design idea materialized out of [..] air. The whole
story, in order:
- Vulkan doesn't allow one VkDeviceMemory to be mapped more than once.
This is rather sad, because since Vulkan best practices suggest to
allocate a large block and suballocate from that, the engine needs
an extra layer that "emulates" mapping the suballocations for the
users but behind the scenes it inevitably has to map the whole
VkDeviceMemory anyway and keep it mapped for as long as any of the
sub-mappings is active.
- Because if it would map just a certain suballocation and then the
user would want to map another suballocation, it would have to
discard the original mapping and create a new one spanning both
suballocations and that has a risk of suddenly being in a different
VM block, making all pointers to the previous mapping invalid.
- The Vulkan Memory Allocator implements this approach of mapping the
whole thing and because of all the bookkeeping it doesn't give a
direct access to the underlying VkDeviceMemory, making it rather
hard to integrate.
Here I realized that:
- Most allocations won't need to be mapped ever, so the hiding and
obfuscation done by VMA isn't needed for those --- and we want
interoperability with 3rd party code, so preventing access to
VkDeviceMemory is out of question.
- There's KHR_dedicated_allocation, which (probably?) wasn't around
when VMA was originally designed. The extension was created because
a dedicated allocation actually *does* make sense in certain
cases and on certain architectures. Providing a way to make those
thus shouldn't be something "temporary, until a real allocator
exists" but rather a well-designed API that's there to stay.
- Except for iGPUs, the usual way to populate a GPU buffer would be to
first copy the data to some host-accessible scratch buffer and then
do a GPU-side copy of that buffer to a device-local memory. The
scratch buffer is very likely to have a vastly different
suballocation scheme than GPU buffers (grow & discard everything
once it's all uploaded, for example) so again trying to put the two
under the same allocator umbrella doesn't make sense.
Thus:
- To avoid implementing a full-blown allocator right from the start,
we'll first provide convenience APIs only for dedicated allocations
-- making it possible to transfer memory ownership to an
Image/Buffer so it can be treated the same way as in GL, and later
having the Image/Buffer constructor implicitly allocate a dedicated
VkDeviceMemory.
- This default allocation will be subsequently equipped with
KHR_dedicated_allocation bits.
- Thanks to the extensible/layered nature of the design, the user is
still capable of being completely in control of allocations,
managing VkDeviceMemory sub-allocations by hand.
Finally, once allocator APIs are figured out, the default Buffer/Image
behavior gets switched from a dedicated allocation to using an
allocator, and dedicated allocation will be only used if the
KHR_dedicated_allocation bit is requested.
6 years ago
|
|
|
#include <Corrade/Utility/DebugStl.h>
|
|
|
|
|
|
|
|
|
|
#include "Magnum/Vk/Image.h"
|
|
|
|
|
#include "Magnum/Vk/Integration.h"
|
|
|
|
|
|
|
|
|
|
namespace Magnum { namespace Vk { namespace Test { namespace {
|
|
|
|
|
|
|
|
|
|
struct ImageTest: TestSuite::Tester {
|
|
|
|
|
explicit ImageTest();
|
|
|
|
|
|
|
|
|
|
void createInfoConstruct();
|
|
|
|
|
void createInfoConstruct1D();
|
|
|
|
|
void createInfoConstruct2D();
|
|
|
|
|
void createInfoConstruct3D();
|
|
|
|
|
void createInfoConstruct1DArray();
|
|
|
|
|
void createInfoConstruct2DArray();
|
|
|
|
|
void createInfoConstructCubeMap();
|
|
|
|
|
void createInfoConstructCubeMapArray();
|
|
|
|
|
void createInfoConstructNoInit();
|
|
|
|
|
void createInfoConstructFromVk();
|
|
|
|
|
|
|
|
|
|
void constructNoCreate();
|
|
|
|
|
void constructCopy();
|
Vk: initial APIs for binding a memory to an image.
You won't believe it, but it took me over a month of sitting on the
shitter until this design idea materialized out of [..] air. The whole
story, in order:
- Vulkan doesn't allow one VkDeviceMemory to be mapped more than once.
This is rather sad, because since Vulkan best practices suggest to
allocate a large block and suballocate from that, the engine needs
an extra layer that "emulates" mapping the suballocations for the
users but behind the scenes it inevitably has to map the whole
VkDeviceMemory anyway and keep it mapped for as long as any of the
sub-mappings is active.
- Because if it would map just a certain suballocation and then the
user would want to map another suballocation, it would have to
discard the original mapping and create a new one spanning both
suballocations and that has a risk of suddenly being in a different
VM block, making all pointers to the previous mapping invalid.
- The Vulkan Memory Allocator implements this approach of mapping the
whole thing and because of all the bookkeeping it doesn't give a
direct access to the underlying VkDeviceMemory, making it rather
hard to integrate.
Here I realized that:
- Most allocations won't need to be mapped ever, so the hiding and
obfuscation done by VMA isn't needed for those --- and we want
interoperability with 3rd party code, so preventing access to
VkDeviceMemory is out of question.
- There's KHR_dedicated_allocation, which (probably?) wasn't around
when VMA was originally designed. The extension was created because
a dedicated allocation actually *does* make sense in certain
cases and on certain architectures. Providing a way to make those
thus shouldn't be something "temporary, until a real allocator
exists" but rather a well-designed API that's there to stay.
- Except for iGPUs, the usual way to populate a GPU buffer would be to
first copy the data to some host-accessible scratch buffer and then
do a GPU-side copy of that buffer to a device-local memory. The
scratch buffer is very likely to have a vastly different
suballocation scheme than GPU buffers (grow & discard everything
once it's all uploaded, for example) so again trying to put the two
under the same allocator umbrella doesn't make sense.
Thus:
- To avoid implementing a full-blown allocator right from the start,
we'll first provide convenience APIs only for dedicated allocations
-- making it possible to transfer memory ownership to an
Image/Buffer so it can be treated the same way as in GL, and later
having the Image/Buffer constructor implicitly allocate a dedicated
VkDeviceMemory.
- This default allocation will be subsequently equipped with
KHR_dedicated_allocation bits.
- Thanks to the extensible/layered nature of the design, the user is
still capable of being completely in control of allocations,
managing VkDeviceMemory sub-allocations by hand.
Finally, once allocator APIs are figured out, the default Buffer/Image
behavior gets switched from a dedicated allocation to using an
allocator, and dedicated allocation will be only used if the
KHR_dedicated_allocation bit is requested.
6 years ago
|
|
|
|
|
|
|
|
void dedicatedMemoryNotDedicated();
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
ImageTest::ImageTest() {
|
|
|
|
|
addTests({&ImageTest::createInfoConstruct,
|
|
|
|
|
&ImageTest::createInfoConstruct1D,
|
|
|
|
|
&ImageTest::createInfoConstruct2D,
|
|
|
|
|
&ImageTest::createInfoConstruct3D,
|
|
|
|
|
&ImageTest::createInfoConstruct1DArray,
|
|
|
|
|
&ImageTest::createInfoConstruct2DArray,
|
|
|
|
|
&ImageTest::createInfoConstructCubeMap,
|
|
|
|
|
&ImageTest::createInfoConstructCubeMapArray,
|
|
|
|
|
&ImageTest::createInfoConstructNoInit,
|
|
|
|
|
&ImageTest::createInfoConstructFromVk,
|
|
|
|
|
|
|
|
|
|
&ImageTest::constructNoCreate,
|
Vk: initial APIs for binding a memory to an image.
You won't believe it, but it took me over a month of sitting on the
shitter until this design idea materialized out of [..] air. The whole
story, in order:
- Vulkan doesn't allow one VkDeviceMemory to be mapped more than once.
This is rather sad, because since Vulkan best practices suggest to
allocate a large block and suballocate from that, the engine needs
an extra layer that "emulates" mapping the suballocations for the
users but behind the scenes it inevitably has to map the whole
VkDeviceMemory anyway and keep it mapped for as long as any of the
sub-mappings is active.
- Because if it would map just a certain suballocation and then the
user would want to map another suballocation, it would have to
discard the original mapping and create a new one spanning both
suballocations and that has a risk of suddenly being in a different
VM block, making all pointers to the previous mapping invalid.
- The Vulkan Memory Allocator implements this approach of mapping the
whole thing and because of all the bookkeeping it doesn't give a
direct access to the underlying VkDeviceMemory, making it rather
hard to integrate.
Here I realized that:
- Most allocations won't need to be mapped ever, so the hiding and
obfuscation done by VMA isn't needed for those --- and we want
interoperability with 3rd party code, so preventing access to
VkDeviceMemory is out of question.
- There's KHR_dedicated_allocation, which (probably?) wasn't around
when VMA was originally designed. The extension was created because
a dedicated allocation actually *does* make sense in certain
cases and on certain architectures. Providing a way to make those
thus shouldn't be something "temporary, until a real allocator
exists" but rather a well-designed API that's there to stay.
- Except for iGPUs, the usual way to populate a GPU buffer would be to
first copy the data to some host-accessible scratch buffer and then
do a GPU-side copy of that buffer to a device-local memory. The
scratch buffer is very likely to have a vastly different
suballocation scheme than GPU buffers (grow & discard everything
once it's all uploaded, for example) so again trying to put the two
under the same allocator umbrella doesn't make sense.
Thus:
- To avoid implementing a full-blown allocator right from the start,
we'll first provide convenience APIs only for dedicated allocations
-- making it possible to transfer memory ownership to an
Image/Buffer so it can be treated the same way as in GL, and later
having the Image/Buffer constructor implicitly allocate a dedicated
VkDeviceMemory.
- This default allocation will be subsequently equipped with
KHR_dedicated_allocation bits.
- Thanks to the extensible/layered nature of the design, the user is
still capable of being completely in control of allocations,
managing VkDeviceMemory sub-allocations by hand.
Finally, once allocator APIs are figured out, the default Buffer/Image
behavior gets switched from a dedicated allocation to using an
allocator, and dedicated allocation will be only used if the
KHR_dedicated_allocation bit is requested.
6 years ago
|
|
|
&ImageTest::constructCopy,
|
|
|
|
|
|
|
|
|
|
&ImageTest::dedicatedMemoryNotDedicated});
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstruct() {
|
|
|
|
|
ImageCreateInfo info{VK_IMAGE_TYPE_2D, ImageUsage::Sampled, VK_FORMAT_R8G8B8A8_UNORM, {256, 128, 1}, 6, 8, 16, ImageCreateInfo::Flag::CubeCompatible};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_2D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 128, 1}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 6);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_SAMPLED_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->tiling, VK_IMAGE_TILING_OPTIMAL);
|
|
|
|
|
CORRADE_COMPARE(info->sharingMode, VK_SHARING_MODE_EXCLUSIVE);
|
|
|
|
|
CORRADE_COMPARE(info->initialLayout, VK_IMAGE_LAYOUT_UNDEFINED);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstruct1D() {
|
|
|
|
|
ImageCreateInfo1D info{ImageUsage::Storage, VK_FORMAT_R8G8B8A8_UNORM, 256, 8, 16, ImageCreateInfo::Flag::MutableFormat};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_1D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 1, 1}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 1);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_STORAGE_BIT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstruct2D() {
|
|
|
|
|
ImageCreateInfo2D info{ImageUsage::TransferDestination, VK_FORMAT_R8G8B8A8_UNORM, {256, 64}, 8, 16, ImageCreateInfo::Flag::MutableFormat};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_2D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 64, 1}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 1);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_TRANSFER_DST_BIT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstruct3D() {
|
|
|
|
|
ImageCreateInfo3D info{ImageUsage::InputAttachment, VK_FORMAT_R8G8B8A8_UNORM, {256, 64, 32}, 8, 16, ImageCreateInfo::Flag::MutableFormat};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_3D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 64, 32}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 1);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstruct1DArray() {
|
|
|
|
|
ImageCreateInfo1DArray info{ImageUsage::TransferDestination, VK_FORMAT_R8G8B8A8_UNORM, {256, 64}, 8, 16, ImageCreateInfo::Flag::MutableFormat};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_1D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 1, 1}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 64);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_TRANSFER_DST_BIT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstruct2DArray() {
|
|
|
|
|
ImageCreateInfo2DArray info{ImageUsage::TransferDestination, VK_FORMAT_R8G8B8A8_UNORM, {256, 64, 32}, 8, 16, ImageCreateInfo::Flag::MutableFormat};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_2D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 64, 1}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 32);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_TRANSFER_DST_BIT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstructCubeMap() {
|
|
|
|
|
ImageCreateInfoCubeMap info{ImageUsage::TransferDestination, VK_FORMAT_R8G8B8A8_UNORM, {256, 256}, 8, 16, ImageCreateInfo::Flag::MutableFormat};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT|VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_2D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 256, 1}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 6);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_TRANSFER_DST_BIT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstructCubeMapArray() {
|
|
|
|
|
ImageCreateInfoCubeMapArray info{ImageUsage::TransferDestination, VK_FORMAT_R8G8B8A8_UNORM, {256, 256, 36}, 8, 16, ImageCreateInfo::Flag::MutableFormat};
|
|
|
|
|
CORRADE_COMPARE(info->flags, VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT|VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->imageType, VK_IMAGE_TYPE_2D);
|
|
|
|
|
CORRADE_COMPARE(info->format, VK_FORMAT_R8G8B8A8_UNORM);
|
|
|
|
|
CORRADE_COMPARE(Vector3i(info->extent), (Vector3i{256, 256, 1}));
|
|
|
|
|
CORRADE_COMPARE(info->mipLevels, 8);
|
|
|
|
|
CORRADE_COMPARE(info->arrayLayers, 36);
|
|
|
|
|
CORRADE_COMPARE(info->samples, VK_SAMPLE_COUNT_16_BIT);
|
|
|
|
|
CORRADE_COMPARE(info->usage, VK_IMAGE_USAGE_TRANSFER_DST_BIT);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstructNoInit() {
|
|
|
|
|
ImageCreateInfo info{NoInit};
|
|
|
|
|
info->sType = VK_STRUCTURE_TYPE_FORMAT_PROPERTIES_2;
|
|
|
|
|
new(&info) ImageCreateInfo{NoInit};
|
|
|
|
|
CORRADE_COMPARE(info->sType, VK_STRUCTURE_TYPE_FORMAT_PROPERTIES_2);
|
|
|
|
|
|
|
|
|
|
CORRADE_VERIFY((std::is_nothrow_constructible<ImageCreateInfo, NoInitT>::value));
|
|
|
|
|
|
|
|
|
|
/* Implicit construction is not allowed */
|
|
|
|
|
CORRADE_VERIFY(!(std::is_convertible<NoInitT, ImageCreateInfo>::value));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::createInfoConstructFromVk() {
|
|
|
|
|
VkImageCreateInfo vkInfo;
|
|
|
|
|
vkInfo.sType = VK_STRUCTURE_TYPE_FORMAT_PROPERTIES_2;
|
|
|
|
|
|
|
|
|
|
ImageCreateInfo info{vkInfo};
|
|
|
|
|
CORRADE_COMPARE(info->sType, VK_STRUCTURE_TYPE_FORMAT_PROPERTIES_2);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::constructNoCreate() {
|
|
|
|
|
{
|
|
|
|
|
Image image{NoCreate};
|
|
|
|
|
CORRADE_VERIFY(!image.handle());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Implicit construction is not allowed */
|
|
|
|
|
CORRADE_VERIFY(!(std::is_convertible<NoCreateT, Image>::value));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void ImageTest::constructCopy() {
|
|
|
|
|
CORRADE_VERIFY(!std::is_copy_constructible<Image>{});
|
|
|
|
|
CORRADE_VERIFY(!std::is_copy_assignable<Image>{});
|
|
|
|
|
}
|
|
|
|
|
|
Vk: initial APIs for binding a memory to an image.
You won't believe it, but it took me over a month of sitting on the
shitter until this design idea materialized out of [..] air. The whole
story, in order:
- Vulkan doesn't allow one VkDeviceMemory to be mapped more than once.
This is rather sad, because since Vulkan best practices suggest to
allocate a large block and suballocate from that, the engine needs
an extra layer that "emulates" mapping the suballocations for the
users but behind the scenes it inevitably has to map the whole
VkDeviceMemory anyway and keep it mapped for as long as any of the
sub-mappings is active.
- Because if it would map just a certain suballocation and then the
user would want to map another suballocation, it would have to
discard the original mapping and create a new one spanning both
suballocations and that has a risk of suddenly being in a different
VM block, making all pointers to the previous mapping invalid.
- The Vulkan Memory Allocator implements this approach of mapping the
whole thing and because of all the bookkeeping it doesn't give a
direct access to the underlying VkDeviceMemory, making it rather
hard to integrate.
Here I realized that:
- Most allocations won't need to be mapped ever, so the hiding and
obfuscation done by VMA isn't needed for those --- and we want
interoperability with 3rd party code, so preventing access to
VkDeviceMemory is out of question.
- There's KHR_dedicated_allocation, which (probably?) wasn't around
when VMA was originally designed. The extension was created because
a dedicated allocation actually *does* make sense in certain
cases and on certain architectures. Providing a way to make those
thus shouldn't be something "temporary, until a real allocator
exists" but rather a well-designed API that's there to stay.
- Except for iGPUs, the usual way to populate a GPU buffer would be to
first copy the data to some host-accessible scratch buffer and then
do a GPU-side copy of that buffer to a device-local memory. The
scratch buffer is very likely to have a vastly different
suballocation scheme than GPU buffers (grow & discard everything
once it's all uploaded, for example) so again trying to put the two
under the same allocator umbrella doesn't make sense.
Thus:
- To avoid implementing a full-blown allocator right from the start,
we'll first provide convenience APIs only for dedicated allocations
-- making it possible to transfer memory ownership to an
Image/Buffer so it can be treated the same way as in GL, and later
having the Image/Buffer constructor implicitly allocate a dedicated
VkDeviceMemory.
- This default allocation will be subsequently equipped with
KHR_dedicated_allocation bits.
- Thanks to the extensible/layered nature of the design, the user is
still capable of being completely in control of allocations,
managing VkDeviceMemory sub-allocations by hand.
Finally, once allocator APIs are figured out, the default Buffer/Image
behavior gets switched from a dedicated allocation to using an
allocator, and dedicated allocation will be only used if the
KHR_dedicated_allocation bit is requested.
6 years ago
|
|
|
void ImageTest::dedicatedMemoryNotDedicated() {
|
|
|
|
|
#ifdef CORRADE_NO_ASSERT
|
|
|
|
|
CORRADE_SKIP("CORRADE_NO_ASSERT defined, can't test assertions");
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
Image image{NoCreate};
|
|
|
|
|
CORRADE_VERIFY(!image.hasDedicatedMemory());
|
|
|
|
|
|
|
|
|
|
std::ostringstream out;
|
|
|
|
|
Error redirectError{&out};
|
|
|
|
|
image.dedicatedMemory();
|
|
|
|
|
CORRADE_COMPARE(out.str(), "Vk::Image::dedicatedMemory(): image doesn't have a dedicated memory\n");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
}}}}
|
|
|
|
|
|
|
|
|
|
CORRADE_TEST_MAIN(Magnum::Vk::Test::ImageTest)
|
