From 0ff15f2872fd689bf188e85a8abc994de4914aaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sun, 23 Aug 2026 12:18:40 +0200 Subject: [PATCH] Platform: this likely should have been `module` also. I have no idea what is gping on in the JS land and why there's always 76 ways to do a certain thing, but since everything else in this file is accessing members via `module.` and not `this.`, these variable accesses likely should do the same. --- src/Magnum/Platform/EmscriptenApplication.js | 4 ++-- src/Magnum/Platform/WindowlessEmscriptenApplication.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Magnum/Platform/EmscriptenApplication.js b/src/Magnum/Platform/EmscriptenApplication.js index d0e07028b..008c90deb 100644 --- a/src/Magnum/Platform/EmscriptenApplication.js +++ b/src/Magnum/Platform/EmscriptenApplication.js @@ -73,11 +73,11 @@ function createMagnumModule(init) { totalDependencies: 0, monitorRunDependencies: function(left) { - this.totalDependencies = Math.max(this.totalDependencies, left); + module.totalDependencies = Math.max(module.totalDependencies, left); if(left) { module.setStatus('Downloading...'); - module.setStatusDescription((this.totalDependencies - left) + ' / ' + this.totalDependencies); + module.setStatusDescription((module.totalDependencies - left) + ' / ' + module.totalDependencies); } else { module.setStatus('Download complete'); module.setStatusDescription(''); diff --git a/src/Magnum/Platform/WindowlessEmscriptenApplication.js b/src/Magnum/Platform/WindowlessEmscriptenApplication.js index 6c5e5cafb..5aaaab2d7 100644 --- a/src/Magnum/Platform/WindowlessEmscriptenApplication.js +++ b/src/Magnum/Platform/WindowlessEmscriptenApplication.js @@ -73,11 +73,11 @@ function createMagnumModule(init) { totalDependencies: 0, monitorRunDependencies: function(left) { - this.totalDependencies = Math.max(this.totalDependencies, left); + module.totalDependencies = Math.max(module.totalDependencies, left); if(left) { module.setStatus('Downloading...'); - module.setStatusDescription((this.totalDependencies - left) + ' / ' + this.totalDependencies); + module.setStatusDescription((module.totalDependencies - left) + ' / ' + module.totalDependencies); } else { module.setStatus('Download complete'); module.setStatusDescription('');