From 251e858d5b8e2dc1da03aac77b31ef3a6048b36c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sun, 26 May 2019 11:36:02 +0200 Subject: [PATCH] Platform: the EmscriptenApplication destructor doesn't need to be virtual. --- src/Magnum/Platform/EmscriptenApplication.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Magnum/Platform/EmscriptenApplication.h b/src/Magnum/Platform/EmscriptenApplication.h index 873464b11..c3e7be55e 100644 --- a/src/Magnum/Platform/EmscriptenApplication.h +++ b/src/Magnum/Platform/EmscriptenApplication.h @@ -210,8 +210,6 @@ class EmscriptenApplication { /** @brief Moving is not allowed */ EmscriptenApplication(EmscriptenApplication&&) = delete; - virtual ~EmscriptenApplication(); - /** @brief Copying is not allowed */ EmscriptenApplication& operator=(const EmscriptenApplication&) = delete; @@ -219,6 +217,10 @@ class EmscriptenApplication { EmscriptenApplication& operator=(EmscriptenApplication&&) = delete; protected: + /* Nobody will need to have (and delete) EmscriptenApplication*, thus + this is faster than public pure virtual destructor */ + ~EmscriptenApplication(); + #ifdef MAGNUM_TARGET_GL /** * @brief Set up a canvas with given configuration for WebGL context