Browse Source

external: include KHR/khrplatform.h absolutely.

Otherwise it requires custom buildsystem users to add
MagnumExternal/OpenGL to include paths, causes issues in Vcpkg and so
on.
findsdl-include-root
Vladimír Vondruš 7 years ago
parent
commit
32ce1f1b43
  1. 3
      modules/FindMagnum.cmake
  2. 10
      src/Magnum/GL/CMakeLists.txt
  3. 2
      src/MagnumExternal/OpenGL/GL/flextGL.h
  4. 1
      src/MagnumExternal/OpenGL/GL/flextGL.h.template
  5. 1
      src/MagnumExternal/OpenGL/GLES2/Emscripten/flextGLEmscripten.h.template
  6. 2
      src/MagnumExternal/OpenGL/GLES2/flextGL.h
  7. 1
      src/MagnumExternal/OpenGL/GLES2/flextGL.h.template
  8. 2
      src/MagnumExternal/OpenGL/GLES2/flextGLEmscripten.h
  9. 2
      src/MagnumExternal/OpenGL/GLES2/flextGLWindowsDesktop.h
  10. 1
      src/MagnumExternal/OpenGL/GLES2/flextGLWindowsDesktop.h.template
  11. 1
      src/MagnumExternal/OpenGL/GLES3/Emscripten/flextGLEmscripten.h.template
  12. 2
      src/MagnumExternal/OpenGL/GLES3/flextGL.h
  13. 1
      src/MagnumExternal/OpenGL/GLES3/flextGL.h.template
  14. 2
      src/MagnumExternal/OpenGL/GLES3/flextGLEmscripten.h
  15. 2
      src/MagnumExternal/OpenGL/GLES3/flextGLWindowsDesktop.h
  16. 1
      src/MagnumExternal/OpenGL/GLES3/flextGLWindowsDesktop.h.template

3
modules/FindMagnum.cmake

@ -805,9 +805,6 @@ foreach(_component ${Magnum_FIND_COMPONENTS})
# GL library # GL library
elseif(_component STREQUAL GL) elseif(_component STREQUAL GL)
set_property(TARGET Magnum::${_component} APPEND PROPERTY
INTERFACE_INCLUDE_DIRECTORIES ${MAGNUM_INCLUDE_DIR}/MagnumExternal/OpenGL)
if(NOT MAGNUM_TARGET_GLES OR MAGNUM_TARGET_DESKTOP_GLES) if(NOT MAGNUM_TARGET_GLES OR MAGNUM_TARGET_DESKTOP_GLES)
# If the GLVND library (CMake 3.11+) was found, link to the # If the GLVND library (CMake 3.11+) was found, link to the
# imported target. Otherwise (and also on all systems except # imported target. Otherwise (and also on all systems except

10
src/Magnum/GL/CMakeLists.txt

@ -182,8 +182,7 @@ add_library(MagnumGLObjects OBJECT
# be overriden with system ones or explicit (MagnumExternal/OpenGL/GLES2/gl2ext.h) # be overriden with system ones or explicit (MagnumExternal/OpenGL/GLES2/gl2ext.h)
# where only our headers will be used # where only our headers will be used
target_include_directories(MagnumGLObjects PUBLIC target_include_directories(MagnumGLObjects PUBLIC
$<TARGET_PROPERTY:Magnum,INTERFACE_INCLUDE_DIRECTORIES> $<TARGET_PROPERTY:Magnum,INTERFACE_INCLUDE_DIRECTORIES>)
${PROJECT_SOURCE_DIR}/src/MagnumExternal/OpenGL)
if(NOT BUILD_STATIC) if(NOT BUILD_STATIC)
target_compile_definitions(MagnumGLObjects PRIVATE "MagnumGLObjects_EXPORTS" "FlextGL_EXPORTS") target_compile_definitions(MagnumGLObjects PRIVATE "MagnumGLObjects_EXPORTS" "FlextGL_EXPORTS")
endif() endif()
@ -211,11 +210,6 @@ if(NOT BUILD_STATIC)
elseif(BUILD_STATIC_PIC) elseif(BUILD_STATIC_PIC)
set_target_properties(MagnumGL PROPERTIES POSITION_INDEPENDENT_CODE ON) set_target_properties(MagnumGL PROPERTIES POSITION_INDEPENDENT_CODE ON)
endif() endif()
# We can use both implicit include path (GLES2/gl2.h) where our headers can
# be overriden with system ones or explicit (MagnumExternal/OpenGL/GLES2/gl2ext.h)
# where only our headers will be used
target_include_directories(MagnumGL PUBLIC
${PROJECT_SOURCE_DIR}/src/MagnumExternal/OpenGL)
target_link_libraries(MagnumGL PUBLIC Magnum) target_link_libraries(MagnumGL PUBLIC Magnum)
if(NOT TARGET_GLES OR TARGET_DESKTOP_GLES) if(NOT TARGET_GLES OR TARGET_DESKTOP_GLES)
# If the GLVND library (CMake 3.11+) was found, link to the imported # If the GLVND library (CMake 3.11+) was found, link to the imported
@ -295,8 +289,6 @@ if(BUILD_TESTS)
$<TARGET_OBJECTS:MagnumGLObjects> $<TARGET_OBJECTS:MagnumGLObjects>
${MagnumGL_FlextGL_SRCS} ${MagnumGL_FlextGL_SRCS}
${MagnumGL_GracefulAssert_SRCS}) ${MagnumGL_GracefulAssert_SRCS})
target_include_directories(MagnumGLTestLib PUBLIC
${PROJECT_SOURCE_DIR}/src/MagnumExternal/OpenGL)
set_target_properties(MagnumGLTestLib PROPERTIES set_target_properties(MagnumGLTestLib PROPERTIES
DEBUG_POSTFIX "-d" DEBUG_POSTFIX "-d"
FOLDER "Magnum/GL") FOLDER "Magnum/GL")

2
src/MagnumExternal/OpenGL/GL/flextGL.h vendored

@ -29,6 +29,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */
@ -118,7 +119,6 @@ void flextGLInit(Magnum::GL::Context& context);
/* Data types */ /* Data types */
#include <KHR/khrplatform.h>
typedef unsigned int GLenum; typedef unsigned int GLenum;
typedef unsigned char GLboolean; typedef unsigned char GLboolean;
typedef unsigned int GLbitfield; typedef unsigned int GLbitfield;

1
src/MagnumExternal/OpenGL/GL/flextGL.h.template vendored

@ -30,6 +30,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */

1
src/MagnumExternal/OpenGL/GLES2/Emscripten/flextGLEmscripten.h.template vendored

@ -27,6 +27,7 @@
*/ */
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */

2
src/MagnumExternal/OpenGL/GLES2/flextGL.h vendored

@ -29,6 +29,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */
@ -87,7 +88,6 @@ void flextGLInit(Magnum::GL::Context& context);
/* Data types */ /* Data types */
#include <KHR/khrplatform.h>
typedef unsigned int GLenum; typedef unsigned int GLenum;
typedef unsigned char GLboolean; typedef unsigned char GLboolean;
typedef unsigned int GLbitfield; typedef unsigned int GLbitfield;

1
src/MagnumExternal/OpenGL/GLES2/flextGL.h.template vendored

@ -30,6 +30,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */

2
src/MagnumExternal/OpenGL/GLES2/flextGLEmscripten.h vendored

@ -26,6 +26,7 @@
*/ */
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */
@ -62,7 +63,6 @@ void flextGLInit(Magnum::GL::Context& context);
/* Data types */ /* Data types */
#include <KHR/khrplatform.h>
typedef unsigned int GLenum; typedef unsigned int GLenum;
typedef unsigned char GLboolean; typedef unsigned char GLboolean;
typedef unsigned int GLbitfield; typedef unsigned int GLbitfield;

2
src/MagnumExternal/OpenGL/GLES2/flextGLWindowsDesktop.h vendored

@ -29,6 +29,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */
@ -82,7 +83,6 @@ void flextGLInit(Magnum::GL::Context& context);
/* Data types */ /* Data types */
#include <KHR/khrplatform.h>
typedef unsigned int GLenum; typedef unsigned int GLenum;
typedef unsigned char GLboolean; typedef unsigned char GLboolean;
typedef unsigned int GLbitfield; typedef unsigned int GLbitfield;

1
src/MagnumExternal/OpenGL/GLES2/flextGLWindowsDesktop.h.template vendored

@ -30,6 +30,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */

1
src/MagnumExternal/OpenGL/GLES3/Emscripten/flextGLEmscripten.h.template vendored

@ -27,6 +27,7 @@
*/ */
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */

2
src/MagnumExternal/OpenGL/GLES3/flextGL.h vendored

@ -29,6 +29,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */
@ -94,7 +95,6 @@ void flextGLInit(Magnum::GL::Context& context);
/* Data types */ /* Data types */
#include <KHR/khrplatform.h>
typedef unsigned int GLenum; typedef unsigned int GLenum;
typedef unsigned char GLboolean; typedef unsigned char GLboolean;
typedef unsigned int GLbitfield; typedef unsigned int GLbitfield;

1
src/MagnumExternal/OpenGL/GLES3/flextGL.h.template vendored

@ -30,6 +30,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */

2
src/MagnumExternal/OpenGL/GLES3/flextGLEmscripten.h vendored

@ -26,6 +26,7 @@
*/ */
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */
@ -68,7 +69,6 @@ void flextGLInit(Magnum::GL::Context& context);
/* Data types */ /* Data types */
#include <KHR/khrplatform.h>
typedef unsigned int GLenum; typedef unsigned int GLenum;
typedef unsigned char GLboolean; typedef unsigned char GLboolean;
typedef unsigned int GLbitfield; typedef unsigned int GLbitfield;

2
src/MagnumExternal/OpenGL/GLES3/flextGLWindowsDesktop.h vendored

@ -29,6 +29,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */
@ -86,7 +87,6 @@ void flextGLInit(Magnum::GL::Context& context);
/* Data types */ /* Data types */
#include <KHR/khrplatform.h>
typedef unsigned int GLenum; typedef unsigned int GLenum;
typedef unsigned char GLboolean; typedef unsigned char GLboolean;
typedef unsigned int GLbitfield; typedef unsigned int GLbitfield;

1
src/MagnumExternal/OpenGL/GLES3/flextGLWindowsDesktop.h.template vendored

@ -30,6 +30,7 @@
#include "Magnum/configure.h" #include "Magnum/configure.h"
#include "Magnum/GL/GL.h" #include "Magnum/GL/GL.h"
#include "MagnumExternal/OpenGL/KHR/khrplatform.h"
/* Defensive include guards */ /* Defensive include guards */

Loading…
Cancel
Save