From 3bb62b77078612d2bac17bb4c6fe46ba1e468ff8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= <mosra@centrum.cz>
Date: Wed, 3 Jun 2015 23:40:32 +0200
Subject: [PATCH] Ability to filter-out driver-specific "success" shader
 compilation logs.

Intel drivers on Windows print out "No errors." when the shader is
compiled/linked successfully. I consider that as unnecessary spam and
filter it out.
---
 src/Magnum/AbstractShaderProgram.cpp         |  7 ++++-
 src/Magnum/Implementation/driverSpecific.cpp | 32 ++++++++++++++++++++
 src/Magnum/Shader.cpp                        |  7 ++++-
 3 files changed, 44 insertions(+), 2 deletions(-)

diff --git a/src/Magnum/AbstractShaderProgram.cpp b/src/Magnum/AbstractShaderProgram.cpp
index 61a9db3a9..9412618e5 100644
--- a/src/Magnum/AbstractShaderProgram.cpp
+++ b/src/Magnum/AbstractShaderProgram.cpp
@@ -44,6 +44,11 @@
 
 namespace Magnum {
 
+namespace Implementation {
+    /* Defined in Implementation/driverSpecific.cpp */
+    bool isProgramLinkLogEmpty(const std::string& result);
+}
+
 Int AbstractShaderProgram::maxVertexAttributes() {
     GLint& value = Context::current()->state().shaderProgram->maxVertexAttributes;
 
@@ -371,7 +376,7 @@ bool AbstractShaderProgram::link(std::initializer_list<std::reference_wrapper<Ab
                 << message;
 
         /* Or just warnings, if any */
-        } else if(!message.empty()) {
+        } else if(!message.empty() && !Implementation::isProgramLinkLogEmpty(message)) {
             Warning out;
             out.setFlag(Debug::NewLineAtTheEnd, false);
             out.setFlag(Debug::SpaceAfterEachValue, false);
diff --git a/src/Magnum/Implementation/driverSpecific.cpp b/src/Magnum/Implementation/driverSpecific.cpp
index aced71d71..52d9c88f0 100644
--- a/src/Magnum/Implementation/driverSpecific.cpp
+++ b/src/Magnum/Implementation/driverSpecific.cpp
@@ -29,6 +29,38 @@
 
 namespace Magnum {
 
+namespace Implementation {
+
+/* Used in Shader.cpp (duh) */
+bool isShaderCompilationLogEmpty(const std::string&);
+bool isShaderCompilationLogEmpty(const std::string& result) {
+    #ifdef CORRADE_TARGET_WINDOWS
+    /* Intel Windows drivers are too chatty */
+    if((Context::current()->detectedDriver() & Context::DetectedDriver::IntelWindows) && result == "No errors.\n")
+        return true;
+    #else
+    static_cast<void>(result);
+    #endif
+
+    return false;
+}
+
+/* Used in AbstractShaderProgram.cpp (duh) */
+bool isProgramLinkLogEmpty(const std::string&);
+bool isProgramLinkLogEmpty(const std::string& result) {
+    #ifdef CORRADE_TARGET_WINDOWS
+    /* Intel Windows drivers are too chatty */
+    if((Context::current()->detectedDriver() & Context::DetectedDriver::IntelWindows) && result == "No errors.\n")
+        return true;
+    #else
+    static_cast<void>(result);
+    #endif
+
+    return false;
+}
+
+}
+
 auto Context::detectedDriver() -> DetectedDrivers {
     if(_detectedDrivers) return *_detectedDrivers;
 
diff --git a/src/Magnum/Shader.cpp b/src/Magnum/Shader.cpp
index 5b2593cb8..67eb89da7 100644
--- a/src/Magnum/Shader.cpp
+++ b/src/Magnum/Shader.cpp
@@ -50,6 +50,11 @@ typedef char GLchar;
 
 namespace Magnum {
 
+namespace Implementation {
+    /* defined in Implementation/driverSpecific.cpp */
+    bool isShaderCompilationLogEmpty(const std::string& result);
+}
+
 namespace {
 
 std::string shaderName(const Shader::Type type) {
@@ -770,7 +775,7 @@ bool Shader::compile(std::initializer_list<std::reference_wrapper<Shader>> shade
                 << message;
 
         /* Or just warnings, if any */
-        } else if(!message.empty()) {
+        } else if(!message.empty() && !Implementation::isShaderCompilationLogEmpty(message)) {
             Warning out;
             out.setFlag(Debug::NewLineAtTheEnd, false);
             out.setFlag(Debug::SpaceAfterEachValue, false);