Browse Source

Use Vector2<unsigned int> for viewport size in Camera instead of ints.

pull/279/head
Vladimír Vondruš 15 years ago
parent
commit
4a23efa307
  1. 23
      src/Camera.cpp
  2. 13
      src/Camera.h

23
src/Camera.cpp

@ -18,7 +18,7 @@
namespace Magnum {
Camera::Camera(Object* parent): Object(parent), _active(0), viewportWidth(0), viewportHeight(0), _aspectRatioPolicy(Extend) {
Camera::Camera(Object* parent): Object(parent), _active(0), _aspectRatioPolicy(Extend) {
setOrthographic(2, 1, 1000);
}
@ -79,11 +79,10 @@ void Camera::setPerspective(GLfloat fov, GLfloat near, GLfloat far) {
fixAspectRatio();
}
void Camera::setViewport(int width, int height) {
glViewport(0, 0, width, height);
void Camera::setViewport(const Math::Vector2<unsigned int>& size) {
glViewport(0, 0, size.x(), size.y());
viewportWidth = width;
viewportHeight = height;
_viewport = size;
fixAspectRatio();
}
@ -113,23 +112,23 @@ void Camera::setDirty() {
void Camera::fixAspectRatio() {
/* Don't divide by zero */
if(viewportWidth == 0 || viewportHeight == 0) {
if(_viewport.x() == 0 || _viewport.y() == 0) {
_projectionMatrix = rawProjectionMatrix;
return;
}
/* Extend on larger side = scale larger side down */
if(_aspectRatioPolicy == Extend) {
_projectionMatrix = ((viewportWidth > viewportHeight) ?
Matrix4::scaling(static_cast<GLfloat>(viewportHeight)/viewportWidth, 1, 1) :
Matrix4::scaling(1, static_cast<GLfloat>(viewportWidth)/viewportHeight, 1)
_projectionMatrix = ((_viewport.x() > _viewport.y()) ?
Matrix4::scaling(static_cast<GLfloat>(_viewport.y())/_viewport.x(), 1, 1) :
Matrix4::scaling(1, static_cast<GLfloat>(_viewport.x())/_viewport.y(), 1)
)*rawProjectionMatrix;
/* Clip on smaller side = scale smaller side up */
} else if(_aspectRatioPolicy == Clip) {
_projectionMatrix = ((viewportWidth > viewportHeight) ?
Matrix4::scaling(1, static_cast<GLfloat>(viewportWidth)/viewportHeight, 1) :
Matrix4::scaling(static_cast<GLfloat>(viewportHeight)/viewportWidth, 1, 1)
_projectionMatrix = ((_viewport.x() > _viewport.y()) ?
Matrix4::scaling(1, static_cast<GLfloat>(_viewport.x())/_viewport.y(), 1) :
Matrix4::scaling(static_cast<GLfloat>(_viewport.y())/_viewport.x(), 1, 1)
)*rawProjectionMatrix;
/* Don't preserve anything */

13
src/Camera.h

@ -110,14 +110,17 @@ class Camera: public Object {
inline Matrix4 projectionMatrix() const { return _projectionMatrix; }
/**
* @brief Set viewport
* @param width Window / buffer width
* @param height Window / buffer height
* @brief Set viewport size
*
* Called when assigning the camera to the scene or when window
* size changes.
*/
void setViewport(int width, int height);
void setViewport(const Math::Vector2<unsigned int>& size);
/** @copydoc setViewport(const Math::Vector2<size_t>& size); */
inline void setViewport(unsigned int width, unsigned int height) {
setViewport({width, height});
}
/**
* Recalculates camera matrix.
@ -138,7 +141,7 @@ class Camera: public Object {
GLfloat _near, _far;
Scene* _active;
int viewportWidth, viewportHeight;
Math::Vector2<unsigned int> _viewport;
AspectRatioPolicy _aspectRatioPolicy;
void fixAspectRatio();

Loading…
Cancel
Save