diff --git a/src/MagnumExternal/Optional/Test/StdOptionalTest.cpp b/src/MagnumExternal/Optional/Test/StdOptionalTest.cpp index 1458ded27..3bab115a0 100644 --- a/src/MagnumExternal/Optional/Test/StdOptionalTest.cpp +++ b/src/MagnumExternal/Optional/Test/StdOptionalTest.cpp @@ -23,6 +23,13 @@ DEALINGS IN THE SOFTWARE. */ +/* Needs to be here otherwise the deprecation warning inside OptionalConverter + is not ignored */ +#ifdef _MSC_VER +#pragma warning(push) +#pragma warning(disable: 4996) +#endif + #include #include #include @@ -45,9 +52,6 @@ StdOptionalTest::StdOptionalTest() { #ifdef __GNUC__ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wdeprecated-declarations" -#elif defined(_MSC_VER) -#pragma warning(push) -#pragma warning(disable: 4996) #endif void StdOptionalTest::conversion() { Debug{} << "Using C++ version" << CORRADE_CXX_STANDARD; @@ -75,10 +79,12 @@ void StdOptionalTest::conversion() { } #ifdef __GNUC__ #pragma GCC diagnostic pop -#elif defined(_MSC_VER) -#pragma warning(pop) #endif }} CORRADE_TEST_MAIN(Magnum::Test::StdOptionalTest) + +#ifdef _MSC_VER +#pragma warning(pop) +#endif