From 4e0a5f3eeafa7bce93026eab88b2084e438cc1a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Thu, 19 Apr 2018 23:02:55 +0200 Subject: [PATCH] Test: expected Mesa failure is only on desktop. On ES given operation is a no-op. Also updated the comment to note it's still valid. --- src/Magnum/Test/CubeMapTextureGLTest.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Magnum/Test/CubeMapTextureGLTest.cpp b/src/Magnum/Test/CubeMapTextureGLTest.cpp index a670d3af5..a67977ebd 100644 --- a/src/Magnum/Test/CubeMapTextureGLTest.cpp +++ b/src/Magnum/Test/CubeMapTextureGLTest.cpp @@ -1389,11 +1389,11 @@ void CubeMapTextureGLTest::invalidateSubImage() { texture.invalidateSubImage(1, Vector3i(2), Vector3i(Vector2i(8), 4)); { - #ifndef MAGNUM_TARGET_WEBGL - /* Mesa (last checked version 12.0.6) treats cube map images as having + #ifndef MAGNUM_TARGET_GLES + /* Mesa (last checked version 18.0.0) treats cube map images as having only single layer instead of 6, so the above invalidation call fails. Relevant source code (scroll up to see imageDepth = 1): - https://github.com/anholt/mesa/blob/1c0ac1976ac7a87bfd2ade47f25047c31527f18a/src/mesa/main/texobj.c#L2179 */ + https://github.com/mesa3d/mesa/blob/051fddb4a9e6abb6f2cf9c892e34c8739983c794/src/mesa/main/texobj.c#L2293 */ CORRADE_EXPECT_FAIL_IF((Context::current().detectedDriver() & Context::DetectedDriver::Mesa), "Broken on Mesa."); #endif