From 53c6d763aef875e488d2e852f4a9ce1e334fc6a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sat, 16 Jun 2018 23:12:43 +0200 Subject: [PATCH] GL: make the usage parameter in Buffer::setData() optional. So simple change, so big usability impact. These hints don't do much to performance anyway. --- doc/changelog.dox | 2 ++ src/Magnum/GL/Buffer.h | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/changelog.dox b/doc/changelog.dox index 3e49fd80a..7c0288668 100644 --- a/doc/changelog.dox +++ b/doc/changelog.dox @@ -73,6 +73,8 @@ See also: - @ref GL::Mesh::draw() and @ref GL::MeshView::draw() now return a reference to self to make method-chained draws (for example using a different shader) possible as well +- The @ref GL::BufferUsage parameter in @ref GL::Buffer::setData() is now + optional, defaults to @ref GL::BufferUsage::StaticDraw @subsubsection changelog-latest-changes-meshtools MeshTools library diff --git a/src/Magnum/GL/Buffer.h b/src/Magnum/GL/Buffer.h index 727832946..542975ca4 100644 --- a/src/Magnum/GL/Buffer.h +++ b/src/Magnum/GL/Buffer.h @@ -1020,16 +1020,16 @@ class MAGNUM_GL_EXPORT Buffer: public AbstractObject { * @fn_gl_extension_keyword{NamedBufferData,EXT,direct_state_access}, * eventually @fn_gl{BindBuffer} and @fn_gl_keyword{BufferData} */ - Buffer& setData(Containers::ArrayView data, BufferUsage usage); + Buffer& setData(Containers::ArrayView data, BufferUsage usage = BufferUsage::StaticDraw); /** @overload */ - template Buffer& setData(const std::vector& data, BufferUsage usage) { + template Buffer& setData(const std::vector& data, BufferUsage usage = BufferUsage::StaticDraw) { setData({data.data(), data.size()}, usage); return *this; } /** @overload */ - template Buffer& setData(const std::array& data, BufferUsage usage) { + template Buffer& setData(const std::array& data, BufferUsage usage = BufferUsage::StaticDraw) { setData({data.data(), data.size()}, usage); return *this; }