Browse Source

[wip] TODOs

sceneconverter
Vladimír Vondruš 4 years ago
parent
commit
573204d3de
  1. 6
      src/Magnum/Trade/AbstractSceneConverter.h

6
src/Magnum/Trade/AbstractSceneConverter.h

@ -810,6 +810,9 @@ class MAGNUM_TRADE_EXPORT AbstractSceneConverter: public PluginManager::Abstract
* @ref setSceneFieldName(), @ref setObjectName(), * @ref setSceneFieldName(), @ref setObjectName(),
* @ref setDefaultScene() * @ref setDefaultScene()
*/ */
// TODO checking IDs?? should maybe document that it should be called
// after all meshes etc are added, and that various converters might be checking some stuff but ignoring other (check dcs)
// TODO document behavior of custom properties -- ignored?
#ifdef DOXYGEN_GENERATING_OUTPUT #ifdef DOXYGEN_GENERATING_OUTPUT
Containers::Optional<UnsignedInt> add(const SceneData& data, Containers::StringView name = {}); Containers::Optional<UnsignedInt> add(const SceneData& data, Containers::StringView name = {});
#else #else
@ -1722,6 +1725,9 @@ class MAGNUM_TRADE_EXPORT AbstractSceneConverter: public PluginManager::Abstract
* detection based on file extension. * detection based on file extension.
*/ */
virtual void doBeginFile(Containers::StringView filename); virtual void doBeginFile(Containers::StringView filename);
// TODO guarantee (and a test) that the string pointed to by
// filename stays in scope until doEndFile()
// TODO and that it's null-terminated (?)
/** /**
* @brief Implementation for @ref endFile() * @brief Implementation for @ref endFile()

Loading…
Cancel
Save