From 5d8686e0b8e474fb835df81d643c12838b33b8cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sat, 22 Jul 2023 20:35:57 +0200 Subject: [PATCH] modules: add a TODO for CMake 3.10. --- modules/FindOpenAL.cmake | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/FindOpenAL.cmake b/modules/FindOpenAL.cmake index 803467832..968ca4680 100644 --- a/modules/FindOpenAL.cmake +++ b/modules/FindOpenAL.cmake @@ -70,6 +70,11 @@ if(TARGET OpenAL OR TARGET OpenAL::OpenAL) # INTERFACE_INCLUDE_DIRECTORIES for some reason (apparently the # $ in there doesn't work or whatever), so let's do # that ourselves. + # + # TODO this could be probably fixable by using target_link_libraries() + # instead of set_target_properties() because it evaluates generator + # expressions, but that needs CMake 3.10+, before that + # target_link_libraries() can't be called on INTERFACE targets. get_target_property(_OPENAL_SOURCE_DIR OpenAL SOURCE_DIR) set_target_properties(OpenAL::OpenAL PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${_OPENAL_SOURCE_DIR}/include/AL)