From 621677bab86e190e0d2b68fe80c321449f24650d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= <mosra@centrum.cz>
Date: Thu, 23 Jan 2025 21:07:00 +0100
Subject: [PATCH] GL: properly test placeholder *BufferImage construction.

Heh, so many holes in the code coverage.
---
 src/Magnum/GL/Test/BufferImageGLTest.cpp | 60 ++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/src/Magnum/GL/Test/BufferImageGLTest.cpp b/src/Magnum/GL/Test/BufferImageGLTest.cpp
index 768669806..63ca42fcc 100644
--- a/src/Magnum/GL/Test/BufferImageGLTest.cpp
+++ b/src/Magnum/GL/Test/BufferImageGLTest.cpp
@@ -41,8 +41,10 @@ struct BufferImageGLTest: OpenGLTester {
 
     void construct();
     void constructGeneric();
+    void constructPlaceholder();
     void constructCompressed();
     void constructCompressedGeneric();
+    void constructCompressedPlaceholder();
     void constructBuffer();
     void constructBufferGeneric();
     void constructBufferCompressed();
@@ -69,8 +71,10 @@ struct BufferImageGLTest: OpenGLTester {
 BufferImageGLTest::BufferImageGLTest() {
     addTests({&BufferImageGLTest::construct,
               &BufferImageGLTest::constructGeneric,
+              &BufferImageGLTest::constructPlaceholder,
               &BufferImageGLTest::constructCompressed,
               &BufferImageGLTest::constructCompressedGeneric,
+              &BufferImageGLTest::constructCompressedPlaceholder,
               &BufferImageGLTest::constructBuffer,
               &BufferImageGLTest::constructBufferGeneric,
               &BufferImageGLTest::constructBufferCompressed,
@@ -142,6 +146,36 @@ void BufferImageGLTest::constructGeneric() {
     #endif
 }
 
+void BufferImageGLTest::constructPlaceholder() {
+    {
+        BufferImage2D a{PixelFormat::Red, PixelType::UnsignedByte};
+
+        CORRADE_COMPARE(a.storage().alignment(), 4);
+        CORRADE_COMPARE(a.format(), PixelFormat::Red);
+        CORRADE_COMPARE(a.type(), PixelType::UnsignedByte);
+        CORRADE_COMPARE(a.pixelSize(), 1);
+        CORRADE_COMPARE(a.size(), Vector2i{});
+        CORRADE_COMPARE(a.dataSize(), 0);
+        CORRADE_VERIFY(a.buffer().id());
+    } {
+        BufferImage2D a{
+            PixelStorage{}
+                /* Even with skip it shouldn't assert on data size */
+                .setSkip({1, 0, 0})
+                .setAlignment(1),
+            PixelFormat::RGB, PixelType::UnsignedByte};
+
+        CORRADE_COMPARE(a.storage().skip(), (Vector3i{1, 0, 0}));
+        CORRADE_COMPARE(a.storage().alignment(), 1);
+        CORRADE_COMPARE(a.format(), PixelFormat::RGB);
+        CORRADE_COMPARE(a.type(), PixelType::UnsignedByte);
+        CORRADE_COMPARE(a.pixelSize(), 3);
+        CORRADE_COMPARE(a.size(), Vector2i{});
+        CORRADE_COMPARE(a.dataSize(), 0);
+        CORRADE_VERIFY(a.buffer().id());
+    }
+}
+
 void BufferImageGLTest::constructCompressed() {
     const char data[] = { 'a', 0, 0, 0, 'b', 0, 0, 0 };
     CompressedBufferImage2D a{
@@ -200,6 +234,32 @@ void BufferImageGLTest::constructCompressedGeneric() {
     #endif
 }
 
+void BufferImageGLTest::constructCompressedPlaceholder() {
+    {
+        CompressedBufferImage2D a;
+
+        CORRADE_COMPARE(a.storage().rowLength(), 0);
+        CORRADE_COMPARE(a.format(), CompressedPixelFormat{});
+        CORRADE_COMPARE(a.size(), Vector2i{});
+        CORRADE_COMPARE(a.dataSize(), 0);
+        CORRADE_VERIFY(a.buffer().id());
+    } {
+        CompressedBufferImage2D a{
+            CompressedPixelStorage{}
+                /* Even with skip it shouldn't assert on data size */
+                .setSkip({1, 0, 0})
+                .setRowLength(12)
+        };
+
+        CORRADE_COMPARE(a.storage().skip(), (Vector3i{1, 0, 0}));
+        CORRADE_COMPARE(a.storage().rowLength(), 12);
+        CORRADE_COMPARE(a.format(), CompressedPixelFormat{});
+        CORRADE_COMPARE(a.size(), Vector2i{});
+        CORRADE_COMPARE(a.dataSize(), 0);
+        CORRADE_VERIFY(a.buffer().id());
+    }
+}
+
 void BufferImageGLTest::constructBuffer() {
     const char data[] = { 'a', 'b', 'c' };
     Buffer buffer;