From 69bf0661742ca6f44a813ce0216728c9a256c40b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Fri, 21 Jan 2022 19:04:39 +0100 Subject: [PATCH] sceneconverter: add a bunch of TODOs. I wanted to convert this to the new MeshTools::filterOnlyAttributes() utility but there's more problems than anticipated, so ... not yet. --- src/Magnum/SceneTools/sceneconverter.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Magnum/SceneTools/sceneconverter.cpp b/src/Magnum/SceneTools/sceneconverter.cpp index 3e22e4873..2c1ac9f9a 100644 --- a/src/Magnum/SceneTools/sceneconverter.cpp +++ b/src/Magnum/SceneTools/sceneconverter.cpp @@ -1047,9 +1047,13 @@ used.)") /* Filter attributes, if requested */ if(!args.value("only-attributes").empty()) { std::set only; + /** @todo drop this awful STL mess once we have an string-to-int + API that can take non-null-terminated string views */ for(const std::string& i: Utility::String::split(args.value("only-attributes"), ' ')) only.insert(std::stoi(i)); + /** @todo use MeshTools::filterOnlyAttributes() once it has a rvalue + overload that transfers ownership */ Containers::Array attributes; for(UnsignedInt i = 0; i != mesh->attributeCount(); ++i) { if(only.find(i) != only.end())