From 6e788cb298279aa32c8d30edd7b3ebe543086205 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Fri, 7 Oct 2022 16:57:43 +0200 Subject: [PATCH] Test: simplify an expression, add a TODO. The Configuration STL stream interface is bad, BAD. --- src/Magnum/Trade/Test/ImageConverterImplementationTest.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Magnum/Trade/Test/ImageConverterImplementationTest.cpp b/src/Magnum/Trade/Test/ImageConverterImplementationTest.cpp index d11adde8c..e4c6f2b09 100644 --- a/src/Magnum/Trade/Test/ImageConverterImplementationTest.cpp +++ b/src/Magnum/Trade/Test/ImageConverterImplementationTest.cpp @@ -180,6 +180,7 @@ void ImageConverterImplementationTest::pluginConfigurationInfo() { void doClose() override {} } importer; + /** @todo UGH, fix the insane Configuration API already */ std::stringstream in; in << R"([configuration] # A comment @@ -204,9 +205,7 @@ subvalue=35 [configuration/group] true=false )"; - Utility::Configuration conf{in}; - - importer.configuration() = Utility::ConfigurationGroup{*conf.group("configuration")}; + importer.configuration() = Utility::ConfigurationGroup{*Utility::Configuration{in}.group("configuration")}; /* Print to visually verify coloring */ {