Browse Source

MeshTools: this NoInit shouldn't have been commented out.

It dates back to 145e055b41 when the code
was written back in 2020. Probably just some debugging leftover, as the
array gets fully overwritten later.

The only vaguely related case where zero-initialization and/or garbage
memory would matter is e496241290, but
that one isn't the case for fuzzy comparison -- here each attribute gets
handled separately and any padding is skipped.
pull/617/head
Vladimír Vondruš 3 years ago
parent
commit
6f3297b8c5
  1. 4
      src/Magnum/MeshTools/RemoveDuplicates.cpp

4
src/Magnum/MeshTools/RemoveDuplicates.cpp

@ -489,8 +489,8 @@ Trade::MeshData removeDuplicatesFuzzy(const Trade::MeshData& data, const Float f
Containers::StridedArrayView2D<UnsignedInt> combinedIndices;
/* If the mesh is not indexed, allocate for vertex count and keep it
unitialized */
combinedIndexStorage = Containers::Array<UnsignedInt>{/*Containers::NoInit,*/
uninitialized */
combinedIndexStorage = Containers::Array<UnsignedInt>{NoInit,
owned.vertexCount()*owned.attributeCount()};
combinedIndices = Containers::StridedArrayView2D<UnsignedInt>{
combinedIndexStorage,

Loading…
Cancel
Save