From 721e10ea0dc2c2cca8380f509039f9f98392d393 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Thu, 4 Jun 2026 18:30:06 +0200 Subject: [PATCH] Trade: test the early return in hasOcclusionRoughnessMetallicTexture(). Interestingly certain CI jobs mark it as covered and others not. --- .../Trade/Test/PbrMetallicRoughnessMaterialDataTest.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Magnum/Trade/Test/PbrMetallicRoughnessMaterialDataTest.cpp b/src/Magnum/Trade/Test/PbrMetallicRoughnessMaterialDataTest.cpp index 8f4a75b85..f1f48b368 100644 --- a/src/Magnum/Trade/Test/PbrMetallicRoughnessMaterialDataTest.cpp +++ b/src/Magnum/Trade/Test/PbrMetallicRoughnessMaterialDataTest.cpp @@ -522,7 +522,14 @@ void PbrMetallicRoughnessMaterialDataTest::texturedImplicitPackedOcclusionRoughn }}; CORRADE_VERIFY(!data.hasOcclusionRoughnessMetallicTexture()); - /* One texture missing */ + /* Roughness / metallic texture missing */ + } { + PbrMetallicRoughnessMaterialData data{{}, { + {MaterialAttribute::OcclusionTexture, 2u}, + }}; + CORRADE_VERIFY(!data.hasOcclusionRoughnessMetallicTexture()); + + /* Occlusion texture missing */ } { PbrMetallicRoughnessMaterialData data{{}, { {MaterialAttribute::NoneRoughnessMetallicTexture, 2u},