From 736f33aaa51a34b9ce2d36668c6e5f674b6d6728 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Thu, 7 Apr 2022 13:21:52 +0200 Subject: [PATCH] Trade: add a defaulted deinlined destructor to AbstractSceneConverter. Otherwise I suppose it'd be generated inline at every call site, including the vtable. Do not want. --- src/Magnum/Trade/AbstractSceneConverter.cpp | 2 ++ src/Magnum/Trade/AbstractSceneConverter.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/Magnum/Trade/AbstractSceneConverter.cpp b/src/Magnum/Trade/AbstractSceneConverter.cpp index b6217d95b..dddd701fc 100644 --- a/src/Magnum/Trade/AbstractSceneConverter.cpp +++ b/src/Magnum/Trade/AbstractSceneConverter.cpp @@ -99,6 +99,8 @@ AbstractSceneConverter::AbstractSceneConverter(PluginManager::Manager{manager, plugin} {} +AbstractSceneConverter::~AbstractSceneConverter() = default; + SceneConverterFeatures AbstractSceneConverter::features() const { const SceneConverterFeatures features = doFeatures(); CORRADE_ASSERT(features, "Trade::AbstractSceneConverter::features(): implementation reported no features", {}); diff --git a/src/Magnum/Trade/AbstractSceneConverter.h b/src/Magnum/Trade/AbstractSceneConverter.h index 5b51dbf69..e3fdf68f4 100644 --- a/src/Magnum/Trade/AbstractSceneConverter.h +++ b/src/Magnum/Trade/AbstractSceneConverter.h @@ -329,6 +329,8 @@ class MAGNUM_TRADE_EXPORT AbstractSceneConverter: public PluginManager::Abstract header. */ explicit AbstractSceneConverter(PluginManager::AbstractManager& manager, const Containers::StringView& plugin); + ~AbstractSceneConverter(); + /** @brief Features supported by this converter */ SceneConverterFeatures features() const;