From 759f4efff6a11ed3044d1d96c3ab37327f0e5838 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Tue, 25 Jul 2023 10:08:20 +0200 Subject: [PATCH] GL: bind properly aligned subranges in the Buffer test. Otherwise it's likely to cause a GL error, which is the case on Qualcomm Adreno. --- src/Magnum/GL/Test/BufferGLTest.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Magnum/GL/Test/BufferGLTest.cpp b/src/Magnum/GL/Test/BufferGLTest.cpp index 472bd35c1..8f94eddf0 100644 --- a/src/Magnum/GL/Test/BufferGLTest.cpp +++ b/src/Magnum/GL/Test/BufferGLTest.cpp @@ -28,6 +28,7 @@ #include #include #include +#include #include "Magnum/GL/Buffer.h" #include "Magnum/GL/Context.h" @@ -246,17 +247,18 @@ void BufferGLTest::bindRange() { #endif /* Check that we have correct offset alignment */ - CORRADE_INTERNAL_ASSERT(256 % Buffer::uniformOffsetAlignment() == 0); + CORRADE_COMPARE_AS(256, Buffer::uniformOffsetAlignment(), + TestSuite::Compare::Divisible); Buffer buffer; buffer.setData({nullptr, 1024}, BufferUsage::StaticDraw) - .bind(Buffer::Target::Uniform, 15, 256, 13); + .bind(Buffer::Target::Uniform, 15, 512, 256); MAGNUM_VERIFY_NO_GL_ERROR(); Buffer::bind(Buffer::Target::Uniform, 7, { - {&buffer, 256, 13}, {}, - {&buffer, 768, 64}}); + {&buffer, 256, 512}, {}, + {&buffer, 768, 256}}); MAGNUM_VERIFY_NO_GL_ERROR(); }