From 7738fcc0118f887299ec8b2502bfe06db6aac331 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Tue, 11 Dec 2018 16:52:57 +0100 Subject: [PATCH] Math: use CORRADE_COMPARE() to compare non-boolean values. Gives better error diagnostics. --- .../Math/Test/StrictWeakOrderingTest.cpp | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/src/Magnum/Math/Test/StrictWeakOrderingTest.cpp b/src/Magnum/Math/Test/StrictWeakOrderingTest.cpp index be58e6f19..f47be05b0 100644 --- a/src/Magnum/Math/Test/StrictWeakOrderingTest.cpp +++ b/src/Magnum/Math/Test/StrictWeakOrderingTest.cpp @@ -82,12 +82,12 @@ void StrictWeakOrderingTest::set() { s.insert({1, 2}); s.insert({2, 3}); - CORRADE_VERIFY(s.size() == 2); - CORRADE_VERIFY(*s.begin() == Vector2(1, 2)); - CORRADE_VERIFY(*s.rbegin() == Vector2(2, 3)); + CORRADE_COMPARE(s.size(), 2); + CORRADE_COMPARE(*s.begin(), Vector2(1, 2)); + CORRADE_COMPARE(*s.rbegin(), Vector2(2, 3)); s.insert({1, 2}); - CORRADE_VERIFY(s.size() == 2); + CORRADE_COMPARE(s.size(), 2); } void StrictWeakOrderingTest::setShort() { @@ -96,12 +96,12 @@ void StrictWeakOrderingTest::setShort() { s.insert({1, 2}); s.insert({2, 3}); - CORRADE_VERIFY(s.size() == 2); - CORRADE_VERIFY(*s.begin() == Vector2(1, 2)); - CORRADE_VERIFY(*s.rbegin() == Vector2(2, 3)); + CORRADE_COMPARE(s.size(), 2); + CORRADE_COMPARE(*s.begin(), Vector2(1, 2)); + CORRADE_COMPARE(*s.rbegin(), Vector2(2, 3)); s.insert({1, 2}); - CORRADE_VERIFY(s.size() == 2); + CORRADE_COMPARE(s.size(), 2); } void StrictWeakOrderingTest::setLess() { @@ -110,12 +110,12 @@ void StrictWeakOrderingTest::setLess() { s.insert({1, 2}); s.insert({2, 3}); - CORRADE_VERIFY(s.size() == 2); - CORRADE_VERIFY(*s.begin() == Vector2(1, 2)); - CORRADE_VERIFY(*s.rbegin() == Vector2(2, 3)); + CORRADE_COMPARE(s.size(), 2); + CORRADE_COMPARE(*s.begin(), Vector2(1, 2)); + CORRADE_COMPARE(*s.rbegin(), Vector2(2, 3)); s.insert({1, 2}); - CORRADE_VERIFY(s.size() == 2); + CORRADE_COMPARE(s.size(), 2); } void StrictWeakOrderingTest::map() { @@ -124,13 +124,13 @@ void StrictWeakOrderingTest::map() { m[Vector2{1, 2}] = 23; m[Vector2{4, 5}] = 55; - CORRADE_VERIFY(m.size() == 2); - CORRADE_VERIFY(m.begin()->second == 23); - CORRADE_VERIFY(m.rbegin()->second == 55); + CORRADE_COMPARE(m.size(), 2); + CORRADE_COMPARE(m.begin()->second, 23); + CORRADE_COMPARE(m.rbegin()->second, 55); m[Vector2{1, 2}] = 99; - CORRADE_VERIFY(m.size() == 2); - CORRADE_VERIFY(m.begin()->second == 99); + CORRADE_COMPARE(m.size(), 2); + CORRADE_COMPARE(m.begin()->second, 99); } void StrictWeakOrderingTest::mapShort() { @@ -139,13 +139,13 @@ void StrictWeakOrderingTest::mapShort() { m[Vector2{1, 2}] = 23; m[Vector2{4, 5}] = 55; - CORRADE_VERIFY(m.size() == 2); - CORRADE_VERIFY(m.begin()->second == 23); - CORRADE_VERIFY(m.rbegin()->second == 55); + CORRADE_COMPARE(m.size(), 2); + CORRADE_COMPARE(m.begin()->second, 23); + CORRADE_COMPARE(m.rbegin()->second, 55); m[Vector2{1, 2}] = 99; - CORRADE_VERIFY(m.size() == 2); - CORRADE_VERIFY(m.begin()->second == 99); + CORRADE_COMPARE(m.size(), 2); + CORRADE_COMPARE(m.begin()->second, 99); } void StrictWeakOrderingTest::mapLess() { @@ -154,13 +154,13 @@ void StrictWeakOrderingTest::mapLess() { m[Vector2{1, 2}] = 23; m[Vector2{4, 5}] = 55; - CORRADE_VERIFY(m.size() == 2); - CORRADE_VERIFY(m.begin()->second == 23); - CORRADE_VERIFY(m.rbegin()->second == 55); + CORRADE_COMPARE(m.size(), 2); + CORRADE_COMPARE(m.begin()->second, 23); + CORRADE_COMPARE(m.rbegin()->second, 55); m[Vector2{1, 2}] = 99; - CORRADE_VERIFY(m.size() == 2); - CORRADE_VERIFY(m.begin()->second == 99); + CORRADE_COMPARE(m.size(), 2); + CORRADE_COMPARE(m.begin()->second, 99); } }}}