Browse Source

Trade: make PbrMetallicRoughnessMaterialData definitions match decls.

OcclusionRoughnessMetallic is close to NoneRoughnessMetallic, which is
already done as such in the header, and as of last commit also in the
test.
pull/651/merge
Vladimír Vondruš 1 year ago
parent
commit
7a959d1edd
  1. 50
      src/Magnum/Trade/PbrMetallicRoughnessMaterialData.cpp

50
src/Magnum/Trade/PbrMetallicRoughnessMaterialData.cpp

@ -55,31 +55,6 @@ bool PbrMetallicRoughnessMaterialData::hasNoneRoughnessMetallicTexture() const {
roughnessTextureLayer() == metalnessTextureLayer();
}
bool PbrMetallicRoughnessMaterialData::hasRoughnessMetallicOcclusionTexture() const {
if(!hasAttribute(MaterialAttribute::RoughnessTexture) ||
!hasAttribute(MaterialAttribute::MetalnessTexture) ||
!hasAttribute(MaterialAttribute::OcclusionTexture))
return false;
const UnsignedInt roughnessTexture = attribute<UnsignedInt>(MaterialAttribute::RoughnessTexture);
if(attribute<UnsignedInt>(MaterialAttribute::MetalnessTexture) != roughnessTexture ||
attribute<UnsignedInt>(MaterialAttribute::OcclusionTexture) != roughnessTexture ||
roughnessTextureSwizzle() != MaterialTextureSwizzle::R ||
metalnessTextureSwizzle() != MaterialTextureSwizzle::G ||
occlusionTextureSwizzle() != MaterialTextureSwizzle::B)
return false;
const Matrix3 roughnessTextureMatrix = this->roughnessTextureMatrix();
const UnsignedInt roughnessTextureCoordinates = this->roughnessTextureCoordinates();
const UnsignedInt roughnessTextureLayer = this->roughnessTextureLayer();
return metalnessTextureMatrix() == roughnessTextureMatrix &&
occlusionTextureMatrix() == roughnessTextureMatrix &&
metalnessTextureCoordinates() == roughnessTextureCoordinates &&
occlusionTextureCoordinates() == roughnessTextureCoordinates &&
metalnessTextureLayer() == roughnessTextureLayer &&
occlusionTextureLayer() == roughnessTextureLayer;
}
bool PbrMetallicRoughnessMaterialData::hasOcclusionRoughnessMetallicTexture() const {
if(!hasAttribute(MaterialAttribute::OcclusionTexture) ||
!hasAttribute(MaterialAttribute::RoughnessTexture) ||
@ -105,6 +80,31 @@ bool PbrMetallicRoughnessMaterialData::hasOcclusionRoughnessMetallicTexture() co
metalnessTextureLayer() == occlusionTextureLayer;
}
bool PbrMetallicRoughnessMaterialData::hasRoughnessMetallicOcclusionTexture() const {
if(!hasAttribute(MaterialAttribute::RoughnessTexture) ||
!hasAttribute(MaterialAttribute::MetalnessTexture) ||
!hasAttribute(MaterialAttribute::OcclusionTexture))
return false;
const UnsignedInt roughnessTexture = attribute<UnsignedInt>(MaterialAttribute::RoughnessTexture);
if(attribute<UnsignedInt>(MaterialAttribute::MetalnessTexture) != roughnessTexture ||
attribute<UnsignedInt>(MaterialAttribute::OcclusionTexture) != roughnessTexture ||
roughnessTextureSwizzle() != MaterialTextureSwizzle::R ||
metalnessTextureSwizzle() != MaterialTextureSwizzle::G ||
occlusionTextureSwizzle() != MaterialTextureSwizzle::B)
return false;
const Matrix3 roughnessTextureMatrix = this->roughnessTextureMatrix();
const UnsignedInt roughnessTextureCoordinates = this->roughnessTextureCoordinates();
const UnsignedInt roughnessTextureLayer = this->roughnessTextureLayer();
return metalnessTextureMatrix() == roughnessTextureMatrix &&
occlusionTextureMatrix() == roughnessTextureMatrix &&
metalnessTextureCoordinates() == roughnessTextureCoordinates &&
occlusionTextureCoordinates() == roughnessTextureCoordinates &&
metalnessTextureLayer() == roughnessTextureLayer &&
occlusionTextureLayer() == roughnessTextureLayer;
}
bool PbrMetallicRoughnessMaterialData::hasNormalRoughnessMetallicTexture() const {
if(!hasAttribute(MaterialAttribute::NormalTexture) ||
!hasAttribute(MaterialAttribute::RoughnessTexture) ||

Loading…
Cancel
Save