From 7c0266f3ebf3226c9ace127fda690b4b5b3cf02e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Thu, 22 Oct 2020 12:54:00 +0200 Subject: [PATCH] ShaderTools: add a TODO. --- src/Magnum/ShaderTools/AbstractConverter.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/Magnum/ShaderTools/AbstractConverter.h b/src/Magnum/ShaderTools/AbstractConverter.h index 75c330ddb..783c81f2f 100644 --- a/src/Magnum/ShaderTools/AbstractConverter.h +++ b/src/Magnum/ShaderTools/AbstractConverter.h @@ -537,6 +537,12 @@ class MAGNUM_SHADERTOOLS_EXPORT AbstractConverter: public PluginManager::Abstrac * * @see @ref ShaderTools-AbstractConverter-usage-callbacks */ + /** @todo once porting away from std::string, it might make sense to + also return a const void view (so it's always implicitly + convertible) and not an Optional (as in, empty but non-null view + would be used for empty files and null would be a failure); then it + also might make sense to have fileCallback() return a char view + again to avoid ugly casts in all user code */ void setInputFileCallback(Containers::Optional>(*callback)(const std::string&, InputFileCallbackPolicy, void*), void* userData = nullptr); /**