Browse Source

SceneTools: fix some variable shadowing warnings.

pull/638/head
Vladimír Vondruš 2 years ago
parent
commit
81855a1764
  1. 10
      src/Magnum/SceneTools/Implementation/combine.h
  2. 12
      src/Magnum/SceneTools/sceneconverter.cpp

10
src/Magnum/SceneTools/Implementation/combine.h

@ -330,11 +330,11 @@ inline Trade::SceneData combineFields(const Trade::SceneMappingType mappingType,
/** @todo this needs Utility::copy() for bits, which is HARD */ /** @todo this needs Utility::copy() for bits, which is HARD */
const Containers::MutableStridedBitArrayView2D dst = itemViews[itemViewMappings[i].second()].bits; const Containers::MutableStridedBitArrayView2D dst = itemViews[itemViewMappings[i].second()].bits;
const std::size_t arraySize = field.fieldArraySize() ? field.fieldArraySize() : 1; const std::size_t arraySize = field.fieldArraySize() ? field.fieldArraySize() : 1;
for(std::size_t i = 0, iMax = field.size(); i != iMax; ++i) { for(std::size_t j = 0, iMax = field.size(); j != iMax; ++j) {
const Containers::StridedBitArrayView1D srcI = src[i]; const Containers::StridedBitArrayView1D srcI = src[j];
const Containers::MutableStridedBitArrayView1D dstI = dst[i]; const Containers::MutableStridedBitArrayView1D dstI = dst[j];
for(std::size_t j = 0; j != arraySize; ++j) for(std::size_t k = 0; k != arraySize; ++k)
dstI.set(j, srcI[j]); dstI.set(k, srcI[k]);
} }
} else { } else {
const Containers::StridedArrayView1D<const void> src = field.fieldData(); const Containers::StridedArrayView1D<const void> src = field.fieldData();

12
src/Magnum/SceneTools/sceneconverter.cpp

@ -1389,11 +1389,11 @@ well, the IDs reference attributes of the first mesh.)")
if(!(Trade::sceneContentsFor(*converter) & Trade::SceneContent::Materials)) { if(!(Trade::sceneContentsFor(*converter) & Trade::SceneContent::Materials)) {
Warning{} << "Ignoring" << materials.size() << "materials not supported by the converter"; Warning{} << "Ignoring" << materials.size() << "materials not supported by the converter";
} else for(UnsignedInt i = 0; i != materials.size(); ++i) { } else for(UnsignedInt j = 0; j != materials.size(); ++j) {
Trade::Implementation::Duration d{conversionTime}; Trade::Implementation::Duration d{conversionTime};
if(!converter->add(materials[i], contents & Trade::SceneContent::Names ? importer->materialName(i) : Containers::String{})) { if(!converter->add(materials[j], contents & Trade::SceneContent::Names ? importer->materialName(j) : Containers::String{})) {
Error{} << "Cannot add material" << i; Error{} << "Cannot add material" << j;
return 1; return 1;
} }
} }
@ -1441,11 +1441,11 @@ well, the IDs reference attributes of the first mesh.)")
if(!(Trade::sceneContentsFor(*converter) & Trade::SceneContent::Scenes)) { if(!(Trade::sceneContentsFor(*converter) & Trade::SceneContent::Scenes)) {
Warning{} << "Ignoring" << scenes.size() << "scenes not supported by the converter"; Warning{} << "Ignoring" << scenes.size() << "scenes not supported by the converter";
} else for(UnsignedInt i = 0; i != scenes.size(); ++i) { } else for(UnsignedInt j = 0; j != scenes.size(); ++j) {
Trade::Implementation::Duration d{conversionTime}; Trade::Implementation::Duration d{conversionTime};
if(!converter->add(scenes[i], contents & Trade::SceneContent::Names ? importer->sceneName(i) : Containers::String{})) { if(!converter->add(scenes[j], contents & Trade::SceneContent::Names ? importer->sceneName(j) : Containers::String{})) {
Error{} << "Cannot add scene" << i; Error{} << "Cannot add scene" << j;
return 1; return 1;
} }
} }

Loading…
Cancel
Save