From 917e692dcbe4f572ec5ac2a1fcea61ea2bde4e74 Mon Sep 17 00:00:00 2001 From: Aaron Gokaslan Date: Sun, 20 Jun 2021 12:06:58 -0400 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Vladimír Vondruš --- src/Magnum/Math/DualComplex.h | 2 +- src/Magnum/Platform/Sdl2Application.cpp | 2 +- src/Magnum/Primitives/Test/GradientTest.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Magnum/Math/DualComplex.h b/src/Magnum/Math/DualComplex.h index e7af7771e..e17daa110 100644 --- a/src/Magnum/Math/DualComplex.h +++ b/src/Magnum/Math/DualComplex.h @@ -108,7 +108,7 @@ template class DualComplex: public Dual> { } /** - * @brief Create dual complexity from rotation complex and translation vector + * @brief Create dual complex from rotation complex and translation vector * @m_since_latest * * @f[ diff --git a/src/Magnum/Platform/Sdl2Application.cpp b/src/Magnum/Platform/Sdl2Application.cpp index 3d210b506..4effb5ee8 100644 --- a/src/Magnum/Platform/Sdl2Application.cpp +++ b/src/Magnum/Platform/Sdl2Application.cpp @@ -887,7 +887,7 @@ bool Sdl2Application::mainLoopIteration() { switch(event.type) { case SDL_WINDOWEVENT: switch(event.window.event) { - /* Not using SDL_WINDOWEVENT_RESIZED, because that does't + /* Not using SDL_WINDOWEVENT_RESIZED, because that doesn't get fired when the window is resized programmatically (such as through setMaxWindowSize()) */ case SDL_WINDOWEVENT_SIZE_CHANGED: { diff --git a/src/Magnum/Primitives/Test/GradientTest.cpp b/src/Magnum/Primitives/Test/GradientTest.cpp index 5e2c8ef12..bb0f852e1 100644 --- a/src/Magnum/Primitives/Test/GradientTest.cpp +++ b/src/Magnum/Primitives/Test/GradientTest.cpp @@ -60,7 +60,7 @@ GradientTest::GradientTest() { using namespace Magnum::Math::Literals; void GradientTest::gradient2D() { - /* The corners could have 0.2, 0.4, 0.6, 0.8 blends */ + /* The corners should have 0.2, 0.4, 0.6, 0.8 blends */ Trade::MeshData gradient = Primitives::gradient2D( {-1.0f, 2.0f}, {0.2f, 0.6f, 1.0f}, {1.0f, -2.0f}, {0.4f, 1.0f, 0.0f}); @@ -115,7 +115,7 @@ void GradientTest::gradient2DVertical() { } void GradientTest::gradient3D() { - /* The corners could have 0.2, 0.4, 0.6, 0.8 blends */ + /* The corners should have 0.2, 0.4, 0.6, 0.8 blends */ Trade::MeshData gradient = Primitives::gradient3D( {-1.0f, 2.0f, -1.5f}, {0.2f, 0.6f, 1.0f}, {1.0f, -2.0f, -1.5f}, {0.4f, 1.0f, 0.0f});