From 968b9a59dc01ff222a933cc40d32e4b5e1e70b36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sat, 2 Aug 2025 13:10:14 +0200 Subject: [PATCH] Platform: add a TODO. Of course it's all extremely messy because there's no better way. --- src/Magnum/Platform/EmscriptenApplication.cpp | 4 ++++ src/Magnum/Platform/GlfwApplication.cpp | 4 ++++ src/Magnum/Platform/Sdl2Application.cpp | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/src/Magnum/Platform/EmscriptenApplication.cpp b/src/Magnum/Platform/EmscriptenApplication.cpp index 89d6c317c..483ef7262 100644 --- a/src/Magnum/Platform/EmscriptenApplication.cpp +++ b/src/Magnum/Platform/EmscriptenApplication.cpp @@ -220,6 +220,10 @@ EmscriptenApplication::EmscriptenApplication(const Arguments& arguments, NoCreat { Utility::Arguments args{Implementation::windowScalingArguments()}; #ifdef MAGNUM_TARGET_GL + /** @todo this means GL::Context is constructed even with Contextless + present, do we actually want that at all? It's just for argument + parsing (which affect GL context creation), so maybe separate that from + the GL::Context somehow? Chicken and egg... */ _context.emplace(NoCreate, args, arguments.argc, arguments.argv); #else /** @todo this is duplicated here, in Sdl2Application and in diff --git a/src/Magnum/Platform/GlfwApplication.cpp b/src/Magnum/Platform/GlfwApplication.cpp index f643ef0eb..9f2fdeac7 100644 --- a/src/Magnum/Platform/GlfwApplication.cpp +++ b/src/Magnum/Platform/GlfwApplication.cpp @@ -85,6 +85,10 @@ GlfwApplication::GlfwApplication(const Arguments& arguments, NoCreateT): { Utility::Arguments args{Implementation::windowScalingArguments()}; #ifdef MAGNUM_TARGET_GL + /** @todo this means GL::Context is constructed even with Contextless + present, do we actually want that at all? It's just for argument + parsing (which affect GL context creation), so maybe separate that from + the GL::Context somehow? Chicken and egg... */ _context.emplace(NoCreate, args, arguments.argc, arguments.argv); #else /** @todo this is duplicated here, in Sdl2Application and in diff --git a/src/Magnum/Platform/Sdl2Application.cpp b/src/Magnum/Platform/Sdl2Application.cpp index 8b25a643d..fd7f431fd 100644 --- a/src/Magnum/Platform/Sdl2Application.cpp +++ b/src/Magnum/Platform/Sdl2Application.cpp @@ -166,6 +166,10 @@ Sdl2Application::Sdl2Application(const Arguments& arguments, NoCreateT): { Utility::Arguments args{Implementation::windowScalingArguments()}; #ifdef MAGNUM_TARGET_GL + /** @todo this means GL::Context is constructed even with Contextless + present, do we actually want that at all? It's just for argument + parsing (which affect GL context creation), so maybe separate that from + the GL::Context somehow? Chicken and egg... */ _context.emplace(NoCreate, args, arguments.argc, arguments.argv); #else /** @todo this is duplicated here, in GlfwApplication and in