From a2dbe53c7d35becef7689a0bb2686666ccf98c2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sat, 7 Dec 2013 20:07:02 +0100 Subject: [PATCH] Platform: no need to have convenience overload of internal constructor. --- src/Platform/AbstractXApplication.cpp | 6 ------ src/Platform/AbstractXApplication.h | 3 --- 2 files changed, 9 deletions(-) diff --git a/src/Platform/AbstractXApplication.cpp b/src/Platform/AbstractXApplication.cpp index c6c846bcd..6ef777eea 100644 --- a/src/Platform/AbstractXApplication.cpp +++ b/src/Platform/AbstractXApplication.cpp @@ -42,12 +42,6 @@ AbstractXApplication::AbstractXApplication(Implementation::AbstractContextHandle createContext(configuration); } -#ifndef DOXYGEN_GENERATING_OUTPUT -AbstractXApplication::AbstractXApplication(Implementation::AbstractContextHandler* contextHandler, const Arguments&): contextHandler(contextHandler), c(nullptr), flags(Flag::Redraw) { - createContext({}); -} -#endif - AbstractXApplication::AbstractXApplication(Implementation::AbstractContextHandler* contextHandler, const Arguments&, std::nullptr_t): contextHandler(contextHandler), c(nullptr), flags(Flag::Redraw) {} void AbstractXApplication::createContext(const Configuration& configuration) { diff --git a/src/Platform/AbstractXApplication.h b/src/Platform/AbstractXApplication.h index ab10cea23..6a3464d2f 100644 --- a/src/Platform/AbstractXApplication.h +++ b/src/Platform/AbstractXApplication.h @@ -137,10 +137,7 @@ class AbstractXApplication { #else protected: #endif - /* These two are split to avoid "invalid use of incomplete type" when - using default argument for configuration */ explicit AbstractXApplication(Implementation::AbstractContextHandler* contextHandler, const Arguments& arguments, const Configuration& configuration); - explicit AbstractXApplication(Implementation::AbstractContextHandler* contextHandler, const Arguments& arguments); explicit AbstractXApplication(Implementation::AbstractContextHandler* contextHandler, const Arguments& arguments, std::nullptr_t);