Browse Source

Added some @todos.

pull/7/head
Vladimír Vondruš 14 years ago
parent
commit
ae78b77b10
  1. 2
      src/AbstractShaderProgram.h
  2. 1
      src/Physics/Box.h
  3. 7
      src/SceneGraph/AbstractTransformation.h
  4. 2
      src/SceneGraph/MatrixTransformation2D.h
  5. 2
      src/SceneGraph/MatrixTransformation3D.h

2
src/AbstractShaderProgram.h

@ -28,6 +28,8 @@
#include "magnumVisibility.h"
/** @todo early asserts (no bool returns?) */
namespace Magnum {
namespace Math {

1
src/Physics/Box.h

@ -30,6 +30,7 @@ namespace Magnum { namespace Physics {
/**
@brief Unit-size box with assigned transformation matrix
@todo Use quat + position + size instead?
@see Box2D, Box3D
*/
template<std::uint8_t dimensions> class PHYSICS_EXPORT Box: public AbstractShape<dimensions> {

7
src/SceneGraph/AbstractTransformation.h

@ -63,6 +63,13 @@ class AbstractTransformation {
* These members must be defined by the implementation.
*/
/**
* @todo Common way to call setClean() on the object after setting
* transformation & disallowing transformation setting on scene,
* so the implementer doesn't forget to do it? It could also
* allow to hide Object::isScene() from unwanted publicity.
*/
/**
* @brief Transformation data type
*

2
src/SceneGraph/MatrixTransformation2D.h

@ -69,7 +69,7 @@ class MatrixTransformation2D: public AbstractTranslationRotationScaling2D<T> {
MatrixTransformation2D<T>* setTransformation(const Math::Matrix3<T>& transformation) {
/* Setting transformation is forbidden for the scene */
/** @todo Assert for this? */
/** @todo Do this in some common code? */
/** @todo Do this in some common code so we don't need to include Object? */
if(!static_cast<Object<MatrixTransformation2D<T>>*>(this)->isScene()) {
_transformation = transformation;
static_cast<Object<MatrixTransformation2D<T>>*>(this)->setDirty();

2
src/SceneGraph/MatrixTransformation3D.h

@ -69,7 +69,7 @@ class MatrixTransformation3D: public AbstractTranslationRotationScaling3D<T> {
MatrixTransformation3D<T>* setTransformation(const Math::Matrix4<T>& transformation) {
/* Setting transformation is forbidden for the scene */
/** @todo Assert for this? */
/** @todo Do this in some common code? */
/** @todo Do this in some common code so we don't need to include Object? */
if(!static_cast<Object<MatrixTransformation3D<T>>*>(this)->isScene()) {
_transformation = transformation;
static_cast<Object<MatrixTransformation3D<T>>*>(this)->setDirty();

Loading…
Cancel
Save