Browse Source

GL: doc that "mesa-broken-dsa-framebuffer-clear" isn't needed on Mesa 25.

pull/674/head
Vladimír Vondruš 1 year ago
parent
commit
b1f6085300
  1. 4
      src/Magnum/GL/Implementation/FramebufferState.cpp
  2. 6
      src/Magnum/GL/Implementation/driverSpecific.cpp

4
src/Magnum/GL/Implementation/FramebufferState.cpp

@ -183,8 +183,8 @@ FramebufferState::FramebufferState(Context& context, Containers::StaticArrayView
/* DSA/non-DSA implementation for framebuffer clearing. Yes, it's because /* DSA/non-DSA implementation for framebuffer clearing. Yes, it's because
Intel Windows drivers are shit, and Mesa 24 seems to be stealing bugs Intel Windows drivers are shit, and Mesa 24 seems to be stealing bugs
from the wrong driver. Doesn't happen on 23 and will hopefully be fixed from the wrong driver. Doesn't happen on 23, doesn't seem to happen on
on 25? */ 25 anymore either. */
#ifndef MAGNUM_TARGET_GLES #ifndef MAGNUM_TARGET_GLES
if(context.isExtensionSupported<Extensions::ARB::direct_state_access>() if(context.isExtensionSupported<Extensions::ARB::direct_state_access>()
&& (!context.versionString().contains("Mesa 24.") || && (!context.versionString().contains("Mesa 24.") ||

6
src/Magnum/GL/Implementation/driverSpecific.cpp

@ -433,8 +433,10 @@ constexpr Containers::StringView KnownWorkarounds[]{
any relevant changelog entry and unfortunately the previous version I had any relevant changelog entry and unfortunately the previous version I had
was only 23.3.5, so it could be anything in between. My hunch is that it's was only 23.3.5, so it could be anything in between. My hunch is that it's
due to some new code that deals with framebuffer compression and which was due to some new code that deals with framebuffer compression and which was
only correctly cleaned up in the non-DSA code path. Or something. See also only correctly cleaned up in the non-DSA code path. Or something. Does not
"intel-windows-broken-dsa-framebuffer-clear" above. */ seem to happen on version 25 anymore. It might have been fixed earlier
already but enabling it for all version 24 patch versions because that's
easiest. See also "intel-windows-broken-dsa-framebuffer-clear" above. */
"mesa-broken-dsa-framebuffer-clear"_s, "mesa-broken-dsa-framebuffer-clear"_s,
#endif #endif

Loading…
Cancel
Save