From b8340f193405ca26bfe60afeabb12379ac97b155 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Mon, 2 May 2022 09:31:57 +0200 Subject: [PATCH] Shaders: make the TODOs even more nightmarish. --- src/Magnum/Shaders/DistanceFieldVectorGL.h | 4 +++- src/Magnum/Shaders/FlatGL.h | 4 +++- src/Magnum/Shaders/MeshVisualizerGL.h | 7 +++++-- src/Magnum/Shaders/PhongGL.h | 4 +++- src/Magnum/Shaders/VectorGL.h | 4 +++- src/Magnum/Shaders/VertexColorGL.h | 4 +++- 6 files changed, 20 insertions(+), 7 deletions(-) diff --git a/src/Magnum/Shaders/DistanceFieldVectorGL.h b/src/Magnum/Shaders/DistanceFieldVectorGL.h index bcefd1d17..1be8f0465 100644 --- a/src/Magnum/Shaders/DistanceFieldVectorGL.h +++ b/src/Magnum/Shaders/DistanceFieldVectorGL.h @@ -260,7 +260,9 @@ template class MAGNUM_SHADERS_EXPORT DistanceFieldVector other is too error-prone, so it needs some other solution (accepting pairs of parameter type and value like in GL context creation, e.g., which will probably need a new enum as reusing Flag - for this might be too confusing) */ + for this might be too confusing); what if some parameters won't be + (unsigned) integers? like a string with shader extensions? make a + whole Configuration class? */ explicit DistanceFieldVectorGL(Flags flags, UnsignedInt materialCount, UnsignedInt drawCount); #endif diff --git a/src/Magnum/Shaders/FlatGL.h b/src/Magnum/Shaders/FlatGL.h index 2042e4ff8..bd76a49c8 100644 --- a/src/Magnum/Shaders/FlatGL.h +++ b/src/Magnum/Shaders/FlatGL.h @@ -582,7 +582,9 @@ template class MAGNUM_SHADERS_EXPORT FlatGL: public GL:: other is too error-prone, so it needs some other solution (accepting pairs of parameter type and value like in GL context creation, e.g., which will probably need a new enum as reusing Flag - for this might be too confusing) */ + for this might be too confusing); what if some parameters won't be + (unsigned) integers? like a string with shader extensions? make a + whole Configuration class? */ explicit FlatGL(Flags flags, UnsignedInt materialCount, UnsignedInt drawCount); #endif diff --git a/src/Magnum/Shaders/MeshVisualizerGL.h b/src/Magnum/Shaders/MeshVisualizerGL.h index 4f5ef90fb..b217f1d39 100644 --- a/src/Magnum/Shaders/MeshVisualizerGL.h +++ b/src/Magnum/Shaders/MeshVisualizerGL.h @@ -486,7 +486,8 @@ class MAGNUM_SHADERS_EXPORT MeshVisualizerGL2D: public Implementation::MeshVisua other is too error-prone, so it needs some other solution (accepting pairs of parameter type and value like in GL context creation, e.g., which will probably need a new enum as reusing Flag - for this might be too confusing) */ + for this might be too confusing); what if some parameters won't be + (unsigned) integers? like a string with shader extensions */ explicit MeshVisualizerGL2D(Flags flags, UnsignedInt materialCount, UnsignedInt drawCount); #endif @@ -1677,7 +1678,9 @@ class MAGNUM_SHADERS_EXPORT MeshVisualizerGL3D: public Implementation::MeshVisua other is too error-prone, so it needs some other solution (accepting pairs of parameter type and value like in GL context creation, e.g., which will probably need a new enum as reusing Flag - for this might be too confusing) */ + for this might be too confusing); what if some parameters won't be + (unsigned) integers? like a string with shader extensions? make a + whole Configuration class? */ explicit MeshVisualizerGL3D(Flags flags, UnsignedInt materialCount, UnsignedInt drawCount); #endif diff --git a/src/Magnum/Shaders/PhongGL.h b/src/Magnum/Shaders/PhongGL.h index 55867a312..1a59c564b 100644 --- a/src/Magnum/Shaders/PhongGL.h +++ b/src/Magnum/Shaders/PhongGL.h @@ -801,7 +801,9 @@ class MAGNUM_SHADERS_EXPORT PhongGL: public GL::AbstractShaderProgram { other is too error-prone, so it needs some other solution (accepting pairs of parameter type and value like in GL context creation, e.g., which will probably need a new enum as reusing Flag - for this might be too confusing) */ + for this might be too confusing); what if some parameters won't be + (unsigned) integers? like a string with shader extensions? make a + whole Configuration class? */ explicit PhongGL(Flags flags, UnsignedInt lightCount, UnsignedInt materialCount, UnsignedInt drawCount); #endif diff --git a/src/Magnum/Shaders/VectorGL.h b/src/Magnum/Shaders/VectorGL.h index b2799dc2a..e1157ba9d 100644 --- a/src/Magnum/Shaders/VectorGL.h +++ b/src/Magnum/Shaders/VectorGL.h @@ -253,7 +253,9 @@ template class MAGNUM_SHADERS_EXPORT VectorGL: public GL other is too error-prone, so it needs some other solution (accepting pairs of parameter type and value like in GL context creation, e.g., which will probably need a new enum as reusing Flag - for this might be too confusing) */ + for this might be too confusing); what if some parameters won't be + (unsigned) integers? like a string with shader extensions? make a + whole Configuration class? */ explicit VectorGL(Flags flags, UnsignedInt materialCount, UnsignedInt drawCount); #endif diff --git a/src/Magnum/Shaders/VertexColorGL.h b/src/Magnum/Shaders/VertexColorGL.h index ed11ad760..3ecdd673f 100644 --- a/src/Magnum/Shaders/VertexColorGL.h +++ b/src/Magnum/Shaders/VertexColorGL.h @@ -244,7 +244,9 @@ template class MAGNUM_SHADERS_EXPORT VertexColorGL: publ other is too error-prone, so it needs some other solution (accepting pairs of parameter type and value like in GL context creation, e.g., which will probably need a new enum as reusing Flag - for this might be too confusing) */ + for this might be too confusing); what if some parameters won't be + (unsigned) integers? like a string with shader extensions? make a + whole Configuration class? */ explicit VertexColorGL(Flags flags, UnsignedInt drawCount); #endif