From b8b6b639194691c1dfedcb6a50ba4bd0e664c150 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Tue, 4 Jun 2013 19:53:25 +0200 Subject: [PATCH] SceneGraph: use `virtual` where it hurts less. Having `virtual` destructor in less templated base is better than having it repeated in five times more subclass specializations. --- src/SceneGraph/FeatureGroup.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/SceneGraph/FeatureGroup.h b/src/SceneGraph/FeatureGroup.h index 8354a7fc3..e40046b1f 100644 --- a/src/SceneGraph/FeatureGroup.h +++ b/src/SceneGraph/FeatureGroup.h @@ -50,7 +50,7 @@ class MAGNUM_SCENEGRAPH_EXPORT AbstractFeatureGroup { template friend class FeatureGroup; explicit AbstractFeatureGroup(); - ~AbstractFeatureGroup(); + virtual ~AbstractFeatureGroup(); void add(AbstractFeature* feature); void remove(AbstractFeature* feature); @@ -80,7 +80,7 @@ class FeatureGroup: public AbstractFeatureGroup { * * Removes all features belonging to this group, but not deletes them. */ - virtual ~FeatureGroup(); + ~FeatureGroup(); /** @brief Whether the group is empty */ bool isEmpty() const { return this->features.empty(); }