From ba88567710dae6a16fdcc0c3527ca442fdec0c94 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sun, 11 Jan 2015 16:06:31 +0100 Subject: [PATCH] Remove redundant `inline` keyword. --- src/Magnum/Color.h | 4 ++-- src/Magnum/Math/RectangularMatrix.h | 10 +++++----- src/Magnum/MeshTools/Interleave.h | 2 +- src/Magnum/MultisampleTexture.h | 4 ++-- src/Magnum/Texture.h | 6 +++--- src/Magnum/TextureArray.h | 4 ++-- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/Magnum/Color.h b/src/Magnum/Color.h index baeb4b3a5..bce8afa46 100644 --- a/src/Magnum/Color.h +++ b/src/Magnum/Color.h @@ -125,10 +125,10 @@ template inline typename BasicColor3::HSV toHSV(typename std::enable } /* Value for full channel (1.0f for floats, 255 for unsigned byte) */ -template inline constexpr typename std::enable_if::value, T>::type fullChannel() { +template constexpr typename std::enable_if::value, T>::type fullChannel() { return T(1); } -template inline constexpr typename std::enable_if::value, T>::type fullChannel() { +template constexpr typename std::enable_if::value, T>::type fullChannel() { return std::numeric_limits::max(); } diff --git a/src/Magnum/Math/RectangularMatrix.h b/src/Magnum/Math/RectangularMatrix.h index d1d4af656..87547b23a 100644 --- a/src/Magnum/Math/RectangularMatrix.h +++ b/src/Magnum/Math/RectangularMatrix.h @@ -583,15 +583,15 @@ extern template Corrade::Utility::Debug MAGNUM_EXPORT operator<<(Corrade::Utilit #endif namespace Implementation { - template inline constexpr Vector diagonalMatrixColumn2(Implementation::Sequence, const T& number) { + template constexpr Vector diagonalMatrixColumn2(Implementation::Sequence, const T& number) { return {(sequence == i ? number : T(0))...}; } - template inline constexpr Vector diagonalMatrixColumn(const T& number) { + template constexpr Vector diagonalMatrixColumn(const T& number) { return diagonalMatrixColumn2(typename Implementation::GenerateSequence::Type(), number); } } -template template inline constexpr RectangularMatrix::RectangularMatrix(Implementation::Sequence, const Vector& diagonal): _data{Implementation::diagonalMatrixColumn(sequence < DiagonalSize ? diagonal[sequence] : T{})...} {} +template template constexpr RectangularMatrix::RectangularMatrix(Implementation::Sequence, const Vector& diagonal): _data{Implementation::diagonalMatrixColumn(sequence < DiagonalSize ? diagonal[sequence] : T{})...} {} template inline Vector RectangularMatrix::row(std::size_t row) const { Vector out; @@ -632,10 +632,10 @@ template inline RectangularMatrix inline constexpr auto RectangularMatrix::diagonal() const -> Vector { return diagonalInternal(typename Implementation::GenerateSequence::Type()); } +template constexpr auto RectangularMatrix::diagonal() const -> Vector { return diagonalInternal(typename Implementation::GenerateSequence::Type()); } #ifndef DOXYGEN_GENERATING_OUTPUT -template template inline constexpr auto RectangularMatrix::diagonalInternal(Implementation::Sequence) const -> Vector { +template template constexpr auto RectangularMatrix::diagonalInternal(Implementation::Sequence) const -> Vector { return {(*this)[sequence][sequence]...}; } #endif diff --git a/src/Magnum/MeshTools/Interleave.h b/src/Magnum/MeshTools/Interleave.h index 6e1761cf3..e8b2a7af2 100644 --- a/src/Magnum/MeshTools/Interleave.h +++ b/src/Magnum/MeshTools/Interleave.h @@ -84,7 +84,7 @@ template typename std::enable_if:: } /* Skip gap */ -inline constexpr std::size_t writeOneInterleaved(std::size_t, char*, std::size_t gap) { return gap; } +constexpr std::size_t writeOneInterleaved(std::size_t, char*, std::size_t gap) { return gap; } /* Write interleaved data */ inline void writeInterleaved(std::size_t, char*) {} diff --git a/src/Magnum/MultisampleTexture.h b/src/Magnum/MultisampleTexture.h index 734ab908c..7ad07eda7 100644 --- a/src/Magnum/MultisampleTexture.h +++ b/src/Magnum/MultisampleTexture.h @@ -40,9 +40,9 @@ namespace Magnum { namespace Implementation { template constexpr GLenum multisampleTextureTarget(); - template<> inline constexpr GLenum multisampleTextureTarget<2>() { return GL_TEXTURE_2D_MULTISAMPLE; } + template<> constexpr GLenum multisampleTextureTarget<2>() { return GL_TEXTURE_2D_MULTISAMPLE; } #ifndef MAGNUM_TARGET_GLES - template<> inline constexpr GLenum multisampleTextureTarget<3>() { return GL_TEXTURE_2D_MULTISAMPLE_ARRAY; } + template<> constexpr GLenum multisampleTextureTarget<3>() { return GL_TEXTURE_2D_MULTISAMPLE_ARRAY; } #endif template VectorTypeFor maxMultisampleTextureSize(); diff --git a/src/Magnum/Texture.h b/src/Magnum/Texture.h index fbaa36cae..7869c0627 100644 --- a/src/Magnum/Texture.h +++ b/src/Magnum/Texture.h @@ -41,10 +41,10 @@ namespace Magnum { namespace Implementation { template constexpr GLenum textureTarget(); #ifndef MAGNUM_TARGET_GLES - template<> inline constexpr GLenum textureTarget<1>() { return GL_TEXTURE_1D; } + template<> constexpr GLenum textureTarget<1>() { return GL_TEXTURE_1D; } #endif - template<> inline constexpr GLenum textureTarget<2>() { return GL_TEXTURE_2D; } - template<> inline constexpr GLenum textureTarget<3>() { + template<> constexpr GLenum textureTarget<2>() { return GL_TEXTURE_2D; } + template<> constexpr GLenum textureTarget<3>() { #ifndef MAGNUM_TARGET_GLES2 return GL_TEXTURE_3D; #else diff --git a/src/Magnum/TextureArray.h b/src/Magnum/TextureArray.h index 1b3ccdc2f..d173290f9 100644 --- a/src/Magnum/TextureArray.h +++ b/src/Magnum/TextureArray.h @@ -42,9 +42,9 @@ namespace Magnum { namespace Implementation { template constexpr GLenum textureArrayTarget(); #ifndef MAGNUM_TARGET_GLES - template<> inline constexpr GLenum textureArrayTarget<1>() { return GL_TEXTURE_1D_ARRAY; } + template<> constexpr GLenum textureArrayTarget<1>() { return GL_TEXTURE_1D_ARRAY; } #endif - template<> inline constexpr GLenum textureArrayTarget<2>() { return GL_TEXTURE_2D_ARRAY; } + template<> constexpr GLenum textureArrayTarget<2>() { return GL_TEXTURE_2D_ARRAY; } } /**