From cef4719d3e0eee7e73a3c21053233197649b7df6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= <mosra@centrum.cz>
Date: Fri, 26 Feb 2021 12:38:48 +0100
Subject: [PATCH] Platform: document why particular things aren't tested.

---
 src/Magnum/Platform/Test/EmscriptenApplicationTest.cpp   | 9 ++++++---
 src/Magnum/Platform/Test/GlfwApplicationTest.cpp         | 2 ++
 src/Magnum/Platform/Test/Sdl2ApplicationTest.cpp         | 2 ++
 .../Platform/Test/WindowlessCglApplicationTest.cpp       | 1 +
 .../Platform/Test/WindowlessGlxApplicationTest.cpp       | 1 +
 .../Platform/Test/WindowlessIosApplicationTest.cpp       | 1 +
 6 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/Magnum/Platform/Test/EmscriptenApplicationTest.cpp b/src/Magnum/Platform/Test/EmscriptenApplicationTest.cpp
index e330277e4..d6c7f068c 100644
--- a/src/Magnum/Platform/Test/EmscriptenApplicationTest.cpp
+++ b/src/Magnum/Platform/Test/EmscriptenApplicationTest.cpp
@@ -170,10 +170,13 @@ EmscriptenApplicationTest::EmscriptenApplicationTest(const Arguments& arguments)
 
     Configuration conf;
     conf.setWindowFlags(Configuration::WindowFlag::Resizable);
+    GLConfiguration glConf;
     if(args.isSet("quiet"))
-        create(conf, GLConfiguration{}.addFlags(GLConfiguration::Flag::QuietLog));
-    else
-        create(conf);
+        glConf.addFlags(GLConfiguration::Flag::QuietLog);
+    /* No GL-specific verbose log in EmscriptenApplication that we'd need to
+       handle explicitly */
+    /* No GPU validation on WebGL */
+    create(conf, glConf);
 
     Debug{} << "window size" << windowSize()
         #ifdef MAGNUM_TARGET_GL
diff --git a/src/Magnum/Platform/Test/GlfwApplicationTest.cpp b/src/Magnum/Platform/Test/GlfwApplicationTest.cpp
index fd7a69e1d..de10695bb 100644
--- a/src/Magnum/Platform/Test/GlfwApplicationTest.cpp
+++ b/src/Magnum/Platform/Test/GlfwApplicationTest.cpp
@@ -131,6 +131,8 @@ GlfwApplicationTest::GlfwApplicationTest(const Arguments& arguments): Platform::
     GLConfiguration glConf;
     if(args.isSet("quiet"))
         glConf.addFlags(GLConfiguration::Flag::QuietLog);
+    /* No GL-specific verbose log in GlfwApplication that we'd need to handle
+       explicitly */
     if(args.isSet("gpu-validation"))
         glConf.addFlags(GLConfiguration::Flag::GpuValidation);
     create(conf, glConf);
diff --git a/src/Magnum/Platform/Test/Sdl2ApplicationTest.cpp b/src/Magnum/Platform/Test/Sdl2ApplicationTest.cpp
index cd6844cbb..edd714162 100644
--- a/src/Magnum/Platform/Test/Sdl2ApplicationTest.cpp
+++ b/src/Magnum/Platform/Test/Sdl2ApplicationTest.cpp
@@ -192,6 +192,8 @@ Sdl2ApplicationTest::Sdl2ApplicationTest(const Arguments& arguments): Platform::
     GLConfiguration glConf;
     if(args.isSet("quiet"))
         glConf.addFlags(GLConfiguration::Flag::QuietLog);
+    /* No GL-specific verbose log in Sdl2Application that we'd need to handle
+       explicitly */
     if(args.isSet("gpu-validation"))
         glConf.addFlags(GLConfiguration::Flag::GpuValidation);
     create(conf, glConf);
diff --git a/src/Magnum/Platform/Test/WindowlessCglApplicationTest.cpp b/src/Magnum/Platform/Test/WindowlessCglApplicationTest.cpp
index a90c98eac..948532418 100644
--- a/src/Magnum/Platform/Test/WindowlessCglApplicationTest.cpp
+++ b/src/Magnum/Platform/Test/WindowlessCglApplicationTest.cpp
@@ -40,6 +40,7 @@ WindowlessCglApplicationTest::WindowlessCglApplicationTest(const Arguments& argu
         .addBooleanOption("quiet").setHelp("quiet", "like --magnum-log quiet, but specified via a Context::Configuration instead")
         .parse(arguments.argc, arguments.argv);
 
+    /* No verbose logs in the app, no GPU validation in CGL either */
     if(args.isSet("quiet"))
         createContext(Configuration{}.addFlags(Configuration::Flag::QuietLog));
     else
diff --git a/src/Magnum/Platform/Test/WindowlessGlxApplicationTest.cpp b/src/Magnum/Platform/Test/WindowlessGlxApplicationTest.cpp
index 298701eaf..4e8719e51 100644
--- a/src/Magnum/Platform/Test/WindowlessGlxApplicationTest.cpp
+++ b/src/Magnum/Platform/Test/WindowlessGlxApplicationTest.cpp
@@ -44,6 +44,7 @@ WindowlessGlxApplicationTest::WindowlessGlxApplicationTest(const Arguments& argu
     Configuration conf;
     if(args.isSet("quiet"))
         conf.addFlags(Configuration::Flag::QuietLog);
+    /* No verbose logs in this app */
     if(args.isSet("gpu-validation"))
         conf.addFlags(Configuration::Flag::GpuValidation);
     createContext(conf);
diff --git a/src/Magnum/Platform/Test/WindowlessIosApplicationTest.cpp b/src/Magnum/Platform/Test/WindowlessIosApplicationTest.cpp
index a1f042616..11b7c6903 100644
--- a/src/Magnum/Platform/Test/WindowlessIosApplicationTest.cpp
+++ b/src/Magnum/Platform/Test/WindowlessIosApplicationTest.cpp
@@ -40,6 +40,7 @@ WindowlessIosApplicationTest::WindowlessIosApplicationTest(const Arguments& argu
         .addBooleanOption("quiet").setHelp("quiet", "like --magnum-log quiet, but specified via a Context::Configuration instead")
         .parse(arguments.argc, arguments.argv);
 
+    /* No verbose logs in the app, no GPU validation in EAGL either */
     if(args.isSet("quiet"))
         createContext(Configuration{}.addFlags(Configuration::Flag::QuietLog));
     else