From df47c732907c8d48eb36abc10c73f562b0706b8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Mon, 17 Apr 2017 14:21:52 +0200 Subject: [PATCH] Math: "fixed" SvdTest on recent Emscripten versions. The algorithm is broken on doubles in different ways in different versions and optimization levels. Hopefully things will get more stable later. --- src/Magnum/Math/Algorithms/Test/SvdTest.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Magnum/Math/Algorithms/Test/SvdTest.cpp b/src/Magnum/Math/Algorithms/Test/SvdTest.cpp index 99647d5ba..133fd40b9 100644 --- a/src/Magnum/Math/Algorithms/Test/SvdTest.cpp +++ b/src/Magnum/Math/Algorithms/Test/SvdTest.cpp @@ -82,8 +82,10 @@ template void SvdTest::test() { /* Test W */ { #ifdef CORRADE_TARGET_EMSCRIPTEN - CORRADE_EXPECT_FAIL_IF((std::is_same::value), - "Some strange problems with Double on recent Emscripten versions (1.36.5 worked fine)."); + CORRADE_EXPECT_FAIL_IF((std::is_same::value && w != expected), + "Some strange problems with Double on recent Emscripten versions " + "(1.36.5 worked fine, 1.37.1 worked fine on larger optimization " + "levels, not on -O1, 1.37.5 works fine again)."); #endif CORRADE_COMPARE(w, expected); }