From e27f17853be2b808f66dc42331c5c7ba12a0468a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Fri, 8 Apr 2022 10:24:51 +0200 Subject: [PATCH] MeshTools: include only what's strictly necessary in public headers. There could eventually be a 2D variant, making Vector3 not needed, people who don't need the AABB won't need the Range include, etc. --- src/Magnum/MeshTools/BoundingVolume.cpp | 3 +++ src/Magnum/MeshTools/BoundingVolume.h | 4 ---- src/Magnum/MeshTools/Test/BoundingVolumeTest.cpp | 2 ++ 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Magnum/MeshTools/BoundingVolume.cpp b/src/Magnum/MeshTools/BoundingVolume.cpp index bb0d1b107..bf717c36a 100644 --- a/src/Magnum/MeshTools/BoundingVolume.cpp +++ b/src/Magnum/MeshTools/BoundingVolume.cpp @@ -26,8 +26,11 @@ #include "BoundingVolume.h" +#include #include +#include "Magnum/Math/Range.h" +#include "Magnum/Math/Vector3.h" #include "Magnum/Math/FunctionsBatch.h" namespace Magnum { namespace MeshTools { diff --git a/src/Magnum/MeshTools/BoundingVolume.h b/src/Magnum/MeshTools/BoundingVolume.h index c3e1ffe9d..0b5582d62 100644 --- a/src/Magnum/MeshTools/BoundingVolume.h +++ b/src/Magnum/MeshTools/BoundingVolume.h @@ -31,11 +31,7 @@ * @m_since_latest */ -#include - #include "Magnum/Magnum.h" -#include "Magnum/Math/Range.h" -#include "Magnum/Math/Vector3.h" #include "Magnum/MeshTools/visibility.h" namespace Magnum { namespace MeshTools { diff --git a/src/Magnum/MeshTools/Test/BoundingVolumeTest.cpp b/src/Magnum/MeshTools/Test/BoundingVolumeTest.cpp index 57b80c86c..afc6ca032 100644 --- a/src/Magnum/MeshTools/Test/BoundingVolumeTest.cpp +++ b/src/Magnum/MeshTools/Test/BoundingVolumeTest.cpp @@ -25,6 +25,7 @@ */ #include +#include #include #include #include @@ -32,6 +33,7 @@ #include "Magnum/Math/FunctionsBatch.h" #include "Magnum/Math/TypeTraits.h" #include "Magnum/Math/Angle.h" +#include "Magnum/Math/Range.h" #include "Magnum/Math/Vector3.h" #include "Magnum/MeshTools/BoundingVolume.h" #include "Magnum/MeshTools/Reference.h"