From eb804489129aa1ec8920ffd0a8f4dd4f0b0288eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sun, 6 May 2012 22:30:39 +0200 Subject: [PATCH] Removed TODOs already done in gcc4.7 branch. It cannot be done another way than with delegating constructors, so it's no reason to keep this todo for gcc 4.6. --- src/Math/Matrix.h | 1 - src/Math/Matrix3.h | 1 - src/Math/Matrix4.h | 1 - src/Math/Vector.h | 1 - src/Math/Vector2.h | 1 - src/Math/Vector3.h | 1 - src/Math/Vector4.h | 1 - 7 files changed, 7 deletions(-) diff --git a/src/Math/Matrix.h b/src/Math/Matrix.h index c494bac64..a329b7a5b 100644 --- a/src/Math/Matrix.h +++ b/src/Math/Matrix.h @@ -96,7 +96,6 @@ template class Matrix { * you to specify value on diagonal. */ inline explicit Matrix(IdentityType = Identity, T value = T(1)): _data() { - /** @todo constexpr how? */ for(size_t i = 0; i != size; ++i) _data[size*i+i] = value; } diff --git a/src/Math/Matrix3.h b/src/Math/Matrix3.h index 73b8e1cf8..22f53b37d 100644 --- a/src/Math/Matrix3.h +++ b/src/Math/Matrix3.h @@ -47,7 +47,6 @@ template class Matrix3: public Matrix { /** @copydoc Matrix::Matrix(IdentityType, T) */ inline constexpr explicit Matrix3(typename Matrix::IdentityType = Matrix::Identity, T value = T(1)): Matrix( - /** @todo Make this in Matrix itself, after it will be constexpr */ value, 0.0f, 0.0f, 0.0f, value, 0.0f, 0.0f, 0.0f, value diff --git a/src/Math/Matrix4.h b/src/Math/Matrix4.h index e5320c25d..776621993 100644 --- a/src/Math/Matrix4.h +++ b/src/Math/Matrix4.h @@ -114,7 +114,6 @@ template class Matrix4: public Matrix { /** @copydoc Matrix::Matrix(IdentityType, T) */ inline constexpr explicit Matrix4(typename Matrix::IdentityType = Matrix::Identity, T value = T(1)): Matrix( - /** @todo Make this in Matrix itself, after it will be constexpr */ value, 0.0f, 0.0f, 0.0f, 0.0f, value, 0.0f, 0.0f, 0.0f, 0.0f, value, 0.0f, diff --git a/src/Math/Vector.h b/src/Math/Vector.h index f98ef6403..938e3ea2f 100644 --- a/src/Math/Vector.h +++ b/src/Math/Vector.h @@ -101,7 +101,6 @@ template class Vector { * @param value Value for all fields */ inline explicit Vector(T value) { - /** @todo constexprize */ for(size_t i = 0; i != size; ++i) _data[i] = value; } diff --git a/src/Math/Vector2.h b/src/Math/Vector2.h index 9da40c2dd..73c9c8465 100644 --- a/src/Math/Vector2.h +++ b/src/Math/Vector2.h @@ -37,7 +37,6 @@ template class Vector2: public Vector { } /** @copydoc Vector::Vector(T) */ - /** @todo Use original constructor when it is constexpr */ inline constexpr explicit Vector2(T value = T()): Vector(value, value) {} /** @copydoc Vector::Vector(const Vector&) */ diff --git a/src/Math/Vector3.h b/src/Math/Vector3.h index e8046c574..13deae51a 100644 --- a/src/Math/Vector3.h +++ b/src/Math/Vector3.h @@ -60,7 +60,6 @@ template class Vector3: public Vector { } /** @copydoc Vector::Vector(T) */ - /** @todo Use original constructor when it is constexpr */ inline constexpr explicit Vector3(T value = T()): Vector(value, value, value) {} /** @copydoc Vector::Vector(const Vector&) */ diff --git a/src/Math/Vector4.h b/src/Math/Vector4.h index 9342800e8..316eec53e 100644 --- a/src/Math/Vector4.h +++ b/src/Math/Vector4.h @@ -44,7 +44,6 @@ template class Vector4: public Vector { inline constexpr Vector4(): Vector(T(0), T(0), T(0), T(1)) {} /** @copydoc Vector::Vector(T) */ - /** @todo Use original constructor when it is constexpr */ inline constexpr explicit Vector4(T value): Vector(value, value, value, value) {} /** @copydoc Vector::Vector(const Vector&) */