From ef771364fe8c03298456989b05aab9a0751c1395 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89mile=20Gr=C3=A9goire?= Date: Thu, 23 Mar 2017 17:14:58 -0400 Subject: [PATCH] Fixed issue in Primitives::Cylinder::solid() where the last ring of faces wouldn't be created when using cap ends because of wrong offset. --- src/Magnum/Primitives/Cylinder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Magnum/Primitives/Cylinder.cpp b/src/Magnum/Primitives/Cylinder.cpp index 9b8497fa9..7182d0793 100644 --- a/src/Magnum/Primitives/Cylinder.cpp +++ b/src/Magnum/Primitives/Cylinder.cpp @@ -59,7 +59,7 @@ Trade::MeshData3D Cylinder::solid(const UnsignedInt rings, const UnsignedInt seg /* Faces */ if(flags & Flag::CapEnds) cylinder.bottomFaceRing(); - cylinder.faceRings(rings, flags & Flag::CapEnds ? 1 : 0); + cylinder.faceRings(rings, flags & Flag::CapEnds ? (1 + segments) : 0); if(flags & Flag::CapEnds) cylinder.topFaceRing(); return cylinder.finalize();