From f178d0d441a33c541641c9998223667325104c66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Sun, 10 Feb 2019 15:50:42 +0100 Subject: [PATCH] Doc++, updated credits and changelog. --- doc/changelog.dox | 18 +++++++++++++++++- doc/credits.dox | 2 ++ .../AnyAudioImporter/AnyImporter.cpp | 3 ++- .../AnyImageConverter/AnyImageConverter.cpp | 3 ++- .../AnyImageImporter/AnyImageImporter.cpp | 3 ++- .../AnySceneImporter/AnySceneImporter.cpp | 3 ++- 6 files changed, 27 insertions(+), 5 deletions(-) diff --git a/doc/changelog.dox b/doc/changelog.dox index db0ca7b05..8f7b0665a 100644 --- a/doc/changelog.dox +++ b/doc/changelog.dox @@ -36,7 +36,23 @@ See also: - @subpage changelog-extras "Extras changelog" - @subpage changelog-examples "Examples changelog" -@anchor changelog-latest +@section changelog-latest Changes since 2019.01 + +@subsection changelog-latest-changes Changes and improvements + +@subsubsection changelog-latest-changes-audio Audio library + +- The @ref Audio::AnyImporter "AnyAudioImporter" plugin now correctly + recognizes also uppercase file extensions (see + [mosra/magnum#312](https://github.com/mosra/magnum/pull/312)) + +@subsubsection changelog-latest-changes-trade Trade library + +- The @ref Trade::AnyImageImporter "AnyImageImporter", + @ref Trade::AnyImageConverter "AnyImageConverter" and + @ref Trade::AnySceneImporter "AnySceneImporter" plugins now correctly + recognize also uppercase file extensions (see + [mosra/magnum#312](https://github.com/mosra/magnum/pull/312)) @section changelog-2019-01 2019.01 diff --git a/doc/credits.dox b/doc/credits.dox index e6315098a..25f59fb0d 100644 --- a/doc/credits.dox +++ b/doc/credits.dox @@ -126,6 +126,8 @@ Are the below lists missing your name or something's wrong? fixes - **Leon Moctezuma** ([\@leonidax](https://github.com/leonidax)) --- bugreports, API design direction +- **Max Schwarz** ([\@xqms](https://github.com/xqms)) --- `Any*` plugin + improvements - **Miguel Martin** ([\@miguelmartin75](https://github.com/miguelmartin75)) --- initial macOS port, various other improvements - **Nathan Ollerenshaw** ([\@matjam](https://github.com/matjam)) --- Ubuntu diff --git a/src/MagnumPlugins/AnyAudioImporter/AnyImporter.cpp b/src/MagnumPlugins/AnyAudioImporter/AnyImporter.cpp index 91f0e5ca4..6716adfc6 100644 --- a/src/MagnumPlugins/AnyAudioImporter/AnyImporter.cpp +++ b/src/MagnumPlugins/AnyAudioImporter/AnyImporter.cpp @@ -47,7 +47,8 @@ void AnyImporter::doClose() { _in = nullptr; } void AnyImporter::doOpenFile(const std::string& filename) { CORRADE_INTERNAL_ASSERT(manager()); - std::string normalized = Utility::String::lowercase(filename); + /** @todo lowercase only the extension, once Directory::split() is done */ + const std::string normalized = Utility::String::lowercase(filename); /* Detect type from extension */ std::string plugin; diff --git a/src/MagnumPlugins/AnyImageConverter/AnyImageConverter.cpp b/src/MagnumPlugins/AnyImageConverter/AnyImageConverter.cpp index d44940884..75e933915 100644 --- a/src/MagnumPlugins/AnyImageConverter/AnyImageConverter.cpp +++ b/src/MagnumPlugins/AnyImageConverter/AnyImageConverter.cpp @@ -46,7 +46,8 @@ auto AnyImageConverter::doFeatures() const -> Features { bool AnyImageConverter::doExportToFile(const ImageView2D& image, const std::string& filename) { CORRADE_INTERNAL_ASSERT(manager()); - std::string normalized = Utility::String::lowercase(filename); + /** @todo lowercase only the extension, once Directory::split() is done */ + const std::string normalized = Utility::String::lowercase(filename); /* Detect type from extension */ std::string plugin; diff --git a/src/MagnumPlugins/AnyImageImporter/AnyImageImporter.cpp b/src/MagnumPlugins/AnyImageImporter/AnyImageImporter.cpp index 51a747a9c..bb7f0f188 100644 --- a/src/MagnumPlugins/AnyImageImporter/AnyImageImporter.cpp +++ b/src/MagnumPlugins/AnyImageImporter/AnyImageImporter.cpp @@ -51,7 +51,8 @@ void AnyImageImporter::doClose() { void AnyImageImporter::doOpenFile(const std::string& filename) { CORRADE_INTERNAL_ASSERT(manager()); - std::string normalized = Utility::String::lowercase(filename); + /** @todo lowercase only the extension, once Directory::split() is done */ + const std::string normalized = Utility::String::lowercase(filename); /* Detect type from extension */ std::string plugin; diff --git a/src/MagnumPlugins/AnySceneImporter/AnySceneImporter.cpp b/src/MagnumPlugins/AnySceneImporter/AnySceneImporter.cpp index c072f78f6..33145f80a 100644 --- a/src/MagnumPlugins/AnySceneImporter/AnySceneImporter.cpp +++ b/src/MagnumPlugins/AnySceneImporter/AnySceneImporter.cpp @@ -61,7 +61,8 @@ void AnySceneImporter::doClose() { void AnySceneImporter::doOpenFile(const std::string& filename) { CORRADE_INTERNAL_ASSERT(manager()); - std::string normalized = Utility::String::lowercase(filename); + /** @todo lowercase only the extension, once Directory::split() is done */ + const std::string normalized = Utility::String::lowercase(filename); /* Detect type from extension */ std::string plugin;