Browse Source

Shaders: this XFAIL only needs to be for llvmpipe on Mesa 20 and older.

pull/680/head
Vladimír Vondruš 10 months ago
parent
commit
f71299a8f1
  1. 7
      src/Magnum/Shaders/Test/PhongGLTest.cpp

7
src/Magnum/Shaders/Test/PhongGLTest.cpp

@ -3513,8 +3513,11 @@ template<PhongGL::Flag flag> void PhongGLTest::renderShininess() {
#ifndef MAGNUM_TARGET_WEBGL #ifndef MAGNUM_TARGET_WEBGL
CORRADE_EXPECT_FAIL_IF(data.shininess == 0.0f && (GL::Context::current().detectedDriver() & GL::Context::DetectedDriver::Mesa) && GL::Context::current().rendererString().contains("AMD"), CORRADE_EXPECT_FAIL_IF(data.shininess == 0.0f && (GL::Context::current().detectedDriver() & GL::Context::DetectedDriver::Mesa) && GL::Context::current().rendererString().contains("AMD"),
"AMD Mesa drivers have a much larger ring for the overflown shininess when it's exactly 0."); "AMD Mesa drivers have a much larger ring for the overflown shininess when it's exactly 0.");
CORRADE_EXPECT_FAIL_IF(data.shininess <= 0.0011f && (GL::Context::current().detectedDriver() & GL::Context::DetectedDriver::Mesa) && GL::Context::current().rendererString().contains("llvmpipe"), CORRADE_EXPECT_FAIL_IF(data.shininess <= 0.0011f &&
"Mesa llvmpipe drivers have a much larger ring for the overflown shininess."); GL::Context::current().rendererString().contains("llvmpipe") &&
(GL::Context::current().versionString().contains("Mesa 20") ||
GL::Context::current().versionString().contains("Mesa 1")),
"Mesa llvmpipe 20 and older drivers have a much larger ring for the overflown shininess.");
#endif #endif
#if defined(CORRADE_TARGET_APPLE) && !defined(CORRADE_TARGET_IOS) #if defined(CORRADE_TARGET_APPLE) && !defined(CORRADE_TARGET_IOS)
CORRADE_EXPECT_FAIL_IF(data.shininess == 0.0f && GL::Context::current().rendererString().contains("AMD"), CORRADE_EXPECT_FAIL_IF(data.shininess == 0.0f && GL::Context::current().rendererString().contains("AMD"),

Loading…
Cancel
Save