From fd6bf547692dac9d44f72d6fa43a3353a884116f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Vondru=C5=A1?= Date: Thu, 8 Aug 2019 21:47:22 +0200 Subject: [PATCH] Shaders: no, these are not expected to fail on macOS. --- src/Magnum/Shaders/Test/DistanceFieldVectorGLTest.cpp | 4 ++-- src/Magnum/Shaders/Test/FlatGLTest.cpp | 2 +- src/Magnum/Shaders/Test/MeshVisualizerGLTest.cpp | 2 +- src/Magnum/Shaders/Test/PhongGLTest.cpp | 2 +- src/Magnum/Shaders/Test/VectorGLTest.cpp | 4 ++-- src/Magnum/Shaders/Test/VertexColorGLTest.cpp | 4 ++-- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Magnum/Shaders/Test/DistanceFieldVectorGLTest.cpp b/src/Magnum/Shaders/Test/DistanceFieldVectorGLTest.cpp index 3658f0192..3beb6c0e7 100644 --- a/src/Magnum/Shaders/Test/DistanceFieldVectorGLTest.cpp +++ b/src/Magnum/Shaders/Test/DistanceFieldVectorGLTest.cpp @@ -48,22 +48,22 @@ DistanceFieldVectorGLTest::DistanceFieldVectorGLTest() { void DistanceFieldVectorGLTest::construct2D() { DistanceFieldVector2D shader; + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } void DistanceFieldVectorGLTest::construct3D() { DistanceFieldVector3D shader; + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } diff --git a/src/Magnum/Shaders/Test/FlatGLTest.cpp b/src/Magnum/Shaders/Test/FlatGLTest.cpp index fd52dc222..c00139add 100644 --- a/src/Magnum/Shaders/Test/FlatGLTest.cpp +++ b/src/Magnum/Shaders/Test/FlatGLTest.cpp @@ -193,11 +193,11 @@ template void FlatGLTest::construct() { Flat shader{data.flags}; CORRADE_COMPARE(shader.flags(), data.flags); + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } diff --git a/src/Magnum/Shaders/Test/MeshVisualizerGLTest.cpp b/src/Magnum/Shaders/Test/MeshVisualizerGLTest.cpp index 4936ce24a..bb5a0b6d5 100644 --- a/src/Magnum/Shaders/Test/MeshVisualizerGLTest.cpp +++ b/src/Magnum/Shaders/Test/MeshVisualizerGLTest.cpp @@ -55,11 +55,11 @@ MeshVisualizerGLTest::MeshVisualizerGLTest() { void MeshVisualizerGLTest::construct() { MeshVisualizer shader; CORRADE_COMPARE(shader.flags(), MeshVisualizer::Flags{}); + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } diff --git a/src/Magnum/Shaders/Test/PhongGLTest.cpp b/src/Magnum/Shaders/Test/PhongGLTest.cpp index 7da63ede2..bb51846c3 100644 --- a/src/Magnum/Shaders/Test/PhongGLTest.cpp +++ b/src/Magnum/Shaders/Test/PhongGLTest.cpp @@ -297,11 +297,11 @@ void PhongGLTest::construct() { Phong shader{data.flags, data.lightCount}; CORRADE_COMPARE(shader.flags(), data.flags); CORRADE_COMPARE(shader.lightCount(), data.lightCount); + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } diff --git a/src/Magnum/Shaders/Test/VectorGLTest.cpp b/src/Magnum/Shaders/Test/VectorGLTest.cpp index 956a48087..3820f965d 100644 --- a/src/Magnum/Shaders/Test/VectorGLTest.cpp +++ b/src/Magnum/Shaders/Test/VectorGLTest.cpp @@ -48,22 +48,22 @@ VectorGLTest::VectorGLTest() { void VectorGLTest::construct2D() { Vector2D shader; + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } void VectorGLTest::construct3D() { Vector3D shader; + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } diff --git a/src/Magnum/Shaders/Test/VertexColorGLTest.cpp b/src/Magnum/Shaders/Test/VertexColorGLTest.cpp index 237c397e8..588b43fdb 100644 --- a/src/Magnum/Shaders/Test/VertexColorGLTest.cpp +++ b/src/Magnum/Shaders/Test/VertexColorGLTest.cpp @@ -48,22 +48,22 @@ VertexColorGLTest::VertexColorGLTest() { void VertexColorGLTest::construct2D() { VertexColor2D shader; + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } } void VertexColorGLTest::construct3D() { VertexColor3D shader; + CORRADE_VERIFY(shader.id()); { #ifdef CORRADE_TARGET_APPLE CORRADE_EXPECT_FAIL("macOS drivers need insane amount of state to validate properly."); #endif - CORRADE_VERIFY(shader.id()); CORRADE_VERIFY(shader.validate().first); } }