magnum

11572 Commits

21 Branches

19 Tags

70 MiB

Tree: 440653dbb8

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	1c1ded5869	Store block size properties in compressed images. Similarly like pixel size is stored in uncompressed images, block size makes it possible to perform size checks on passed data, slice the images and so on. It only took over a decade to get that done. The block properties coming from CompressedPixelStorage are currently expected to be either not set at all or exactly match what's stored in the image for given format. The PixelStorage will get eventually deprecated in favor of a simpler and more flexible representation, but that's another big chunk of work so it's first done like this. The GL library tests currently blow up on various assertions and it isn't yet updated to make use of the known format properties instead of querying them from GL. That'll be done in the following commits.	10 months ago
Vladimír Vondruš	f8926fbdbd	Fix pixel storage data size calculation for compressed images. The tests now pass, but this damn GL pixel storage API is so convoluted with so many redundant and mutually conflicting degrees of freedom that it's impossible to be sure. Looking forward to when I can finally drop that thing and calculate it on the fly from just size + stride, like it should have been from the start.	10 months ago
Vladimír Vondruš	143dc48e87	Move the occupiedCompressedImageDataSize() helper to the GL library. It's used only there and only to supply a silly argument to a broken API. Unfortunately back when adding this utility in 2015 I didn't document what was it for, which initially made me think it's there for some suspicious reason. Well, the reason is suspicious, but for an entirely different reason.	10 months ago

Author

SHA1

Message

Date

Vladimír Vondruš

1c1ded5869

Store block size properties in compressed images.

Similarly like pixel size is stored in uncompressed images, block size
makes it possible to perform size checks on passed data, slice the images
and so on. It only took over a decade to get that done.

The block properties coming from CompressedPixelStorage are currently
expected to be either not set at all or exactly match what's stored in
the image for given format. The PixelStorage will get eventually
deprecated in favor of a simpler and more flexible representation, but
that's another big chunk of work so it's first done like this.

The GL library tests currently blow up on various assertions and it
isn't yet updated to make use of the known format properties instead of
querying them from GL. That'll be done in the following commits.

10 months ago

Vladimír Vondruš

f8926fbdbd

Fix pixel storage data size calculation for compressed images.

The tests now pass, but this damn GL pixel storage API is so convoluted
with so many redundant and mutually conflicting degrees of freedom that
it's impossible to be sure. Looking forward to when I can finally drop
that thing and calculate it on the fly from just size + stride, like it
should have been from the start.

10 months ago

Vladimír Vondruš

143dc48e87

Move the occupiedCompressedImageDataSize() helper to the GL library.

It's used only there and only to supply a silly argument to a broken API.
Unfortunately back when adding this utility in 2015 I didn't document
what was it for, which initially made me think it's there for some
suspicious reason. Well, the reason is suspicious, but for an entirely
different reason.

10 months ago

3 Commits (440653dbb8815ba28fd20203acae711dbb8b14b4)