magnum

Commit Graph

Author	SHA1	Message	Date
Vladimír Vondruš	602f08881b	Trade: ensure AbstractImporter::fooForName() returns indices in bounds. I just accidentally returned a wrong index from a SceneData backwards compatibility wrapper and realized it'd be good to have that checked always.	5 years ago
Vladimír Vondruš	29ac7b5a4d	Trade,ShaderTools: add addFlags() / clearFlags() to all plugin interfaces. There will be Flag::FlipY for images at some point, enabled by default for compatibility with existing GL code, and so it makes sense to start discouraging setFlags() as early as possible to avoid people resetting the default by accident. Also update the imageconverter, sceneconverter and shaderconverter utils to use these instead of setFlags().	5 years ago
Vladimír Vondruš	3d136503d8	Updated copyright year.	5 years ago
Vladimír Vondruš	ddb7185417	Trade: make AbstractImporter::defaultScene() const. Makes more sense as the function isn't expected to fail (and thus any kind of lazy population is not possible as it would be too late for error checks anyway). Not updating interface strings even though this is an ABI break because we're doing that right after the skin import interface bump.	6 years ago
Vladimír Vondruš	5217f48499	Trade: disallow custom deleters in AbstractImporter::skinXD().	6 years ago
Vladimír Vondruš	8c24ea19d3	Trade: skin import in AbstractImporter.	6 years ago
Vladimír Vondruš	3bfe0f1d7f	Trade: minor test cleanup.	6 years ago
Vladimír Vondruš	b5fdfc2474	Trade: check for custom MaterialData deleters in AbstractImporter. And adapt MaterialData and the deprecated PhongMaterialData constructor to follow these rules. Basically the same as done for ImageData and MeshData.	6 years ago
Vladimír Vondruš	0ec8e002fb	Trade: return Optional instead of Pointer from *Importer::material(). The plugin interface version got bumped to avoid ABI issues when loading plugins that weren't updated for the change, but apart from that this shouldn't be a breaking change, as the API returns a type that can be both an Optional and a Pointer.	6 years ago
Vladimír Vondruš	769e27340f	Trade: AbstractImporter::importerState() expects a file to be opened. The restriction was there always, but was undocumented and untested.	6 years ago
Vladimír Vondruš	19e0e96d74	Updated copyright year.	6 years ago
Vladimír Vondruš	0bdb70fcf6	Trade: add flags to AbstractImporter and AbstractImageConverter.	6 years ago
Vladimír Vondruš	877c13efa3	Trade: minor.	6 years ago
Vladimír Vondruš	65a2ced2a7	Make this compile and test cleanly with CORRADE_NO_ASSERT defined.	6 years ago
Vladimír Vondruš	c3299ad3c5	Trade: print a message when named thing is not found. Otherwise it's hard to distinguish whether it's a particular importer fault (failing without a message) or if the name is not found.	6 years ago
Vladimír Vondruš	4a6e5ff5a4	Trade: reduce needless duplication in AbstractImporter test. Should have done this since the beginning, would save my carpal tunnels a bit.	6 years ago
Vladimír Vondruš	9f73be569a	Trade: adapt tests etc to PhongMaterialData rework.	6 years ago
Vladimír Vondruš	27f6cc309d	Trade: allow specifying explicit vertex count on MeshData construction. Until now, except for an attribute-less index-less mesh, the vertex count was only implicitly taken from passed attributes, but it was severely limiting: - There was no way to set vertex count for an attribute-less indexed mesh, which didn't make sense - All code that made non-owning MeshData instances referencing another MeshData had to explicitly handle the attribute-less corner case to avoid vertex count getting lost - Offset-only attributes couldn't be used to specify static layout of meshes with dynamic vertex count, causing unnecessary extra allocations especially in the Primitives library.	6 years ago
Vladimír Vondruš	9425c23d0a	Trade: support mesh level import in AbstractImporter. Similar to image mip level import, but this is largely left to be importer-specific. For example PLY defines per-face data and sometimes one might want to import them as-is, without them being turned into a per-vertex property.	6 years ago
Vladimír Vondruš	a02e9465d6	Trade: allow retrieving importer data directly by name.	6 years ago
Vladimír Vondruš	006790969a	Trade, MeshTools: deprecate MeshDataXD and everything that uses it.	6 years ago
Vladimír Vondruš	0f4a5adb4d	Trade: deprecate AbstractImporter interfaces for MeshDataXD. For backwards compatibility these will delegate to the new MeshData interfaces for 3D (and nothing for 2D, because so far there were no 2D scene importers).	6 years ago
Vladimír Vondruš	036fced749	Trade: whitelist (exported) growable array deleters in imported data.	6 years ago
Vladimír Vondruš	93e6dc2c54	Trade: make AnimationTrackData constructors explicit. There's a ton of parameters and it's just unreadable without.	6 years ago
Vladimír Vondruš	6ddcc0b1ae	Trade: make it possible to construct AnimationData from track init list. Easier to write. Need to take extra care with default deleters.	6 years ago
Vladimír Vondruš	4011e3006d	Trade: allow non-owning aray deleters passed through Importer APIs.	6 years ago
Vladimír Vondruš	fb1fdf6105	Trade: implement Importer interfaces for the new MeshData. Deprecating of the old ones comes later.	6 years ago
Vladimír Vondruš	dfacd7fb2d	Trade: support mip levels in image import. There's a new level option in each imageND() API, plus an imageNDLevelCount() query to get image level count.	6 years ago
Vladimír Vondruš	19dd7a0176	Move Feature[s] enums from inside plugin classes outside. Too annoyingly long to type. Also added a debug output operator for the FontConverterFeature enums, for some reason there were none.	6 years ago
Vladimír Vondruš	7be062a71a	Trade: clean up unused & harmful error redirection in tests. Copypaste error. This would hide graceful assert messages, which is not good.	7 years ago
Vladimír Vondruš	22458f22b5	Trade: minor cleanup.	7 years ago
Vladimír Vondruš	84fc685c87	Trade, Audio: explicitly disallow custom deleters returned from plugins.	7 years ago
Vladimír Vondruš	387a12c329	Trade: provide less useless OOB assert messages. If this would be there yesterday already, it would made my debugging session of `image2D(-1)` immediately obvious (instead of wasting 20 minutes).	7 years ago
Vladimír Vondruš	a035220552	Trade: this was not needed. And made some valid asserts too silent to be heard.	7 years ago
Vladimír Vondruš	71a9f1bbbf	Reserve zero [Compressed]PixelFormat for an invalid value. Catches accidents better -- just look at the diff. Might catch accidents in your code now as well, so beware!	7 years ago
Vladimír Vondruš	3626562e1d	Adapted to Corrade changes. Mostly missing includes now.	7 years ago
Vladimír Vondruš	589a912fa1	Trade: accept const references in AbstractImporter file callbacks.	7 years ago
Vladimír Vondruš	29d88c8a71	Trade: test also plain AbstractImporter::openData().	7 years ago
Vladimír Vondruš	76c8603bc7	Trade: clean up unnecessary cruft in the AbstractImporter test.	7 years ago
Vladimír Vondruš	e3fc0d037c	Move Trade::ImporterFileCallbackPolicy to InputFileCallbackPolicy. It'll get used outside of the root namespace and since the callbacks tend to be quite complex, it would be silly to require users to implement one callback for Trade, one for Text and one for Audio, for example.	7 years ago
Vladimír Vondruš	f9f3df69de	Get rid of std::unique_ptr.	7 years ago
Vladimír Vondruš	24b8ff086c	Removed std::optional backwards compatibility. This was a dirty mess. Good riddance. Also removing the include from the header now, as it has a forward declaration and thus is not needed.	7 years ago
Vladimír Vondruš	2149f7b869	Wrap all tests in unnamed namespaces. This makes the compiler warn about test cases that aren't ever used, which is a good thing.	7 years ago
Vladimír Vondruš	e6b7aa12fa	Updated copyright year.	7 years ago
Vladimír Vondruš	b93fcd6d9d	Trade: camera type, projection size and aspect ratio support.	8 years ago
Vladimír Vondruš	fa10765198	Trade: alpha mode, alpha mask and double sided material properties.	8 years ago
Vladimír Vondruš	1260d51dc1	Trade: redesign importer file callbacks. The original implementation had a few problems: - If a file callback was set, openFile() was unconditionally calling right into doOpenData(), making it impossible for the importer to know the original path for correctly supplying paths to additional files. Now, if the importer supports Feature::FileCallback, doOpenFile() is always called. It's also possible for the importer to save the path and then just delegate to the base doOpenFile() implementation -- it will handle the file callbacks correctly too. - If the importer supported neither FileCallback nor OpenData and callbacks were set, the original doOpenFile() implementation was called without any warning or anything, doing silently a bad thing. Now in this case setFileCallbacks() asserts -- programmer has to check for feature support first. - It was not possible for the file callback to indicate file opening failure -- in general, empty files are valid, so a nullptr ArrayView is also a valid file. Now the callback return an Optional instead.	8 years ago
Vladimír Vondruš	0b3e1e3068	Trade: animation import interface in AbstractImporter.	8 years ago
Vladimír Vondruš	d6189cb74f	Trade: support for file loading callbacks in AbstractImporter.	8 years ago
Vladimír Vondruš	f9267735ae	Trade: exhaustive test for AbstractImporter. Also fixed typos and copypaste errors in assertion messages; added assertions to functions that should never get called.	8 years ago

1 2

62 Commits (56cc2d6f91076251b969c4327d0cb9d9ec5a531c)